fix(aws-elasticache): fix endpointPort references in dependencies #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The ServerlessCache construct casts the underlying resource endpoint port to a number using the javascript Number constructor, which isn't properly handled when using the value in other resources.
Description of changes
The fix is to instead use
Token.asNumberwhich properly registers the token and tracks dependencies.Description of how you validated changes
Added a unit test to verify the value across stacks.
Checklist
aws-part in the scope of the PR title if the PR relates to a specific AWS service module.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license