🐛 Only delele serviceaccount managed by the addon agent #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 36.57% 36.90% +0.32%
==========================================
Files 19 19
Lines 987 1000 +13
==========================================
+ Hits 361 369 +8
- Misses 606 610 +4
- Partials 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhujian7
changed the title
zhujian7
force-pushed
the
delete-managed-sa
branch
from
a3f287d to
2fe7d10
Compare
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
delete-managed-sa
branch
from
2fe7d10 to
08f32a1
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 70597d9
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When delete a managedserviceaccount, only delele the serviceaccount that is created by the addon agent
Related issue(s)
Fixes #