Add fields to the Policy CRD for policy ordering #49
Conversation
api/v1/policy_types.go
Outdated
| ObjectDefinition runtime.RawExtension `json:"objectDefinition"` | ||
| ObjectDefinition runtime.RawExtension `json:"objectDefinition"` | ||
| ExtraDependencies []PolicyDependency `json:"extraDependencies,omitempty"` | ||
| IgnorePending bool `json:"ignorePending,omitempty"` |
There was a problem hiding this comment.
Could you document this field so it shows up in the CRD?
There was a problem hiding this comment.
Thanks for catching that! I also added some more comments for other fields, somewhat based on the doc at https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.6/html/governance/governance#policy-yaml-structure
JustinKuli
force-pushed
the
policy-ordering-crd
branch
from
905faad
to
39cc35b
Compare
|
This looks great! Just a few nitpicks. |
Refs: - open-cluster-management-io/enhancements#74 Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
policy-ordering-crd
branch
from
39cc35b
to
41974dd
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JustinKuli Please also update the CRD in the addon controller, as the sync is currently failing: |
Refs: - open-cluster-management-io/governance-policy-propagator#49 Signed-off-by: Justin Kulikauskas <[email protected]>
Refs: - open-cluster-management-io/governance-policy-propagator#49 Signed-off-by: Justin Kulikauskas <[email protected]>
Refs: - open-cluster-management-io/governance-policy-propagator#49 Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit e62c392d021408d4c50e955ec4bd33bf5002339f)
Refs: - open-cluster-management-io/governance-policy-propagator#49 Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit e62c392d021408d4c50e955ec4bd33bf5002339f)
Refs:
Signed-off-by: Justin Kulikauskas [email protected]