Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Gatekeeper syncing in hosted mode #72

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Disable Gatekeeper syncing in hosted mode #72

merged 2 commits into from
Apr 11, 2023

Conversation

dhaiducek
Copy link
Member

@dhaiducek dhaiducek marked this pull request as ready for review April 6, 2023 17:36
JustinKuli
JustinKuli previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these failures caused by something we're already looking at? (We have a lot of things in the air right now)

@openshift-ci openshift-ci bot added the lgtm label Apr 6, 2023
@dhaiducek
Copy link
Member Author

Are these failures caused by something we're already looking at? (We have a lot of things in the air right now)

I hadn't noticed it had failed (and I'm kind of surprised it did). Since these aren't framework E2E tests, it sounds like there might be something more here I need to investigate...

@dhaiducek
Copy link
Member Author

It's doing some whitespace chomping, and I'll bet it no longer needs to do that with a raw string...

@openshift-ci openshift-ci bot removed the lgtm label Apr 6, 2023
@dhaiducek
Copy link
Member Author

dhaiducek commented Apr 6, 2023 •
edited
Loading

Well. It wasn't that. Looks like I have some actual investigating to do!

@dhaiducek
Copy link
Member Author

Blocked by:

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5f40507 into open-cluster-management-io:main Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinKuli JustinKuli JustinKuli approved these changes

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@JustinKuli JustinKuli

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhaiducek @JustinKuli @openshift-merge-robot