Create the cluster namespace when a hub is imported by a global hub #104
Conversation
mprahl
force-pushed
the
global-hub
branch
5 times, most recently
from
a43a8ae
to
4d897a1
Compare
|
@yiraeChristineKim and @dhaiducek and @gparvin this is ready for review now. |
pkg/addon/policyframework/manifests/managedclusterchart/templates/namespace.yaml
Outdated
Show resolved
Hide resolved
|
What is global hub? |
The global hub concept allows a hub to manage other hubs called regional hubs. The regional hubs manage the non-hub managed clusters. The concept came because the architecture on etcd doesn't scale after a certain point. |
When syncPoliciesOnMulticlusterHub is true, it's indicating that the hub is imported by a global hub. The namespace must be created on the hub to sync policies from the global hub. The namespace also needs to be cleaned up when uninstalled, so the clean up pod is now enabled in this scenario too. Relates: https://issues.redhat.com/browse/ACM-7655 Signed-off-by: mprahl <[email protected]>
| "policy.open-cluster-management.io/sync-policies-on-multicluster-hub-", | ||
| ) | ||
|
|
||
| Kubectl("annotate", "-n", cluster.clusterName, "-f", case1ManagedClusterAddOnCR, "policy-addon-pause-") |
There was a problem hiding this comment.
Annotations are usually key and value aren't they?
There was a problem hiding this comment.
This syntax removes the annotation.
| By(logPrefix + "deleting the managedclusteraddon") | ||
| Kubectl("delete", "-n", cluster.clusterName, "-f", case1ManagedClusterAddOnCR, "--timeout=90s") | ||
| deploy = GetWithTimeout( | ||
| cluster.clusterClient, gvrDeployment, case1DeploymentName, addonNamespace, false, 30, |
There was a problem hiding this comment.
I doubt about 30 secs.. Would you test several times more?
There was a problem hiding this comment.
I just triggered a rerun.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 21c01f0
into
open-cluster-management-io:main
When syncPoliciesOnMulticlusterHub is true, it's indicating that the hub is imported by a global hub. The namespace must be created on the hub to sync policies from the global hub. The namespace also needs to be cleaned up when uninstalled, so the clean up pod is now enabled in this scenario too.
Relates:
https://issues.redhat.com/browse/ACM-7655