Skip to content

Commit

Permalink
Use a unique ClusterRoleBinding name to account for hosted mode
Browse files Browse the repository at this point in the history
Prior to this, the governance-policy-framework ClusterRoleBinding would
have the same name for every hosted cluster on the hosting/management
cluster. The generated ManifestWork objects would overwrite each other
since it did not append to the subjects array. Using a unique name per
hosted cluster like the config-policy-controller does will resolve this.

Relates:
https://issues.redhat.com/browse/ACM-4486

Signed-off-by: mprahl <[email protected]>
  • Loading branch information
mprahl authored and openshift-merge-robot committed Mar 23, 2023
1 parent 2022a3a commit cce56fa
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "controller.rolename" . }}-binding
name: ocm:{{ .Release.Namespace }}:{{ include "controller.fullname" . }}
labels:
app: {{ include "controller.fullname" . }}
chart: {{ include "controller.chart" . }}
Expand Down

0 comments on commit cce56fa

Please sign in to comment.