BUG: event-driven mode not requeueing some enforcement errors #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings the variables into a tighter scope. Signed-off-by: Justin Kulikauskas <[email protected]>
In event-driven mode, some errors occuring during enforcement were not getting to the right level, and not causing the reconcile to be requeued, for example when the namespace for an object does not exist yet. Refs: - https://issues.redhat.com/browse/ACM-13431 Signed-off-by: Justin Kulikauskas <[email protected]>
Just re-queueing when this error occurs works, but causes the error to be logged repeatedly. We can do better in this specific case, since we know what to wait for. Refs: - https://issues.redhat.com/browse/ACM-13431 Signed-off-by: Justin Kulikauskas <[email protected]>
The package that does the merging has a dependency which seems to be upset at our current version of go. Signed-off-by: Justin Kulikauskas <[email protected]>
This is another specific kind of error where we can do better than just re-queueing every second. Refs: - https://issues.redhat.com/browse/ACM-13431 Signed-off-by: Justin Kulikauskas <[email protected]>
mprahl
approved these changes
Sep 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ee9f873
into
open-cluster-management-io:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.