Use --server-side for null test
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
case7-refactor2
branch
2 times, most recently
from
45dba4e to
4d42888
Compare
This test is failing downstream but seems to pass for me locally. Refactoring to at least get more informative results. Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
case7-refactor2
branch
from
4d42888 to
0501cb4
Compare
mprahl
approved these changes
Aug 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a14266b
into
open-cluster-management-io:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In K8s v1.31,
kubectl createandkubectl applyclient-side both treatnullas removing the field, which breaks our test that is trying to test when the field is actually set tonull. Usingkubectl apply --server-sidefixes it.ref: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.31.md
Also refactor to get more informative results, including: