Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the controller-runtime cache to get the decryption key #284

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Aug 5, 2024

The stale cached decryption key detection logic was not 100% accurate, so just use the controller-runtime cache every time.

Relates:
https://issues.redhat.com/browse/ACM-11497

The stale cached decryption key detection logic was not 100% accurate, so
just use the controller-runtime cache every time.

Relates:
https://issues.redhat.com/browse/ACM-11497

Signed-off-by: mprahl <[email protected]>
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec8a702 into open-cluster-management-io:main Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants