-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry evaluating the policy if a mapping error occurs #275
Retry evaluating the policy if a mapping error occurs #275
Conversation
/hold for fixing tests |
@yiraeChristineKim and @dhaiducek could you please look again? I definitely rushed this PR but now it seems to be working well. |
/unhold |
Since there is no watch for the condition to resolve itself, the policy would never become compliant once the CRD is available. Signed-off-by: mprahl <[email protected]>
@yiraeChristineKim I made a small change to the test which should get the same result but make it 10 seconds faster. |
EDIT: Nevermind. I looked at the latest change rather than the actual code and got confused. 😬 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4903591
into
open-cluster-management-io:main
Since there is no watch for the condition to resolve itself, the policy would never become compliant once the CRD is available.