Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry evaluating the policy if a mapping error occurs #275

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Jul 17, 2024

Since there is no watch for the condition to resolve itself, the policy would never become compliant once the CRD is available.

@mprahl mprahl force-pushed the fix-crd-missing branch from f5b38f7 to dad28b1 Compare July 17, 2024 20:05
@mprahl mprahl requested a review from dhaiducek July 17, 2024 20:05
@mprahl mprahl force-pushed the fix-crd-missing branch from dad28b1 to bd0c70e Compare July 17, 2024 20:36
@mprahl mprahl requested a review from dhaiducek July 17, 2024 20:37
@yiraeChristineKim
Copy link
Contributor

/hold for fixing tests

@mprahl
Copy link
Member Author

mprahl commented Jul 18, 2024

@yiraeChristineKim and @dhaiducek could you please look again? I definitely rushed this PR but now it seems to be working well.

@yiraeChristineKim
Copy link
Contributor

/unhold

Since there is no watch for the condition to resolve itself, the policy
would never become compliant once the CRD is available.

Signed-off-by: mprahl <[email protected]>
@mprahl
Copy link
Member Author

mprahl commented Jul 18, 2024

@yiraeChristineKim I made a small change to the test which should get the same result but make it 10 seconds faster.

@mprahl mprahl requested a review from yiraeChristineKim July 18, 2024 13:37
@dhaiducek
Copy link
Member

dhaiducek commented Jul 18, 2024

@yiraeChristineKim I made a small change to the test which should get the same result but make it 10 seconds faster.

@mprahl But that defeats the purpose of the test, which is looking for a retry (i.e. at least 2 total)

EDIT: Nevermind. I looked at the latest change rather than the actual code and got confused. 😬

Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants