✨ Adding support for adding aws tags #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @qiujian16 do you know why tests fail? It seems to be related to go version, not related to our change. |
|
hrm that is strange... @zhujian7 and idea? |
|
@jaswalkiranavtar could you rebase this PR to have a try after it is merged? |
jaswalkiranavtar
force-pushed
the
feature/GWCP-72203
branch
from
121376c to
ace9b55
Compare
jeffw17
force-pushed
the
feature/GWCP-72203
branch
5 times, most recently
from
5d4b153 to
cfe3db0
Compare
Signed-off-by: Jeffrey Wong <[email protected]>
jeffw17
force-pushed
the
feature/GWCP-72203
branch
from
cfe3db0 to
6d7e5d4
Compare
|
this looks like a flaky test.. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaswalkiranavtar, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1f52a8c
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes open-cluster-management-io/ocm#514