Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang and deps #205

Merged

Conversation

qiujian16
Copy link
Member

No description provided.

Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuezhaojun
Copy link
Member

/lgtm

Signed-off-by: Jian Qiu <[email protected]>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (ac07a46) to head (b17c5d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   23.54%   14.96%   -8.58%     
==========================================
  Files           9       32      +23     
  Lines        1015     1717     +702     
==========================================
+ Hits          239      257      +18     
- Misses        758     1438     +680     
- Partials       18       22       +4     
Flag Coverage Δ
unit 14.96% <ø> (-8.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member

xuezhaojun commented Aug 19, 2024

@qiujian16 All tests passed, can I force merge it because the known reason that go 1.22 will count pkgs without _test.go as 0%?

@xuezhaojun
Copy link
Member

/lgtm

Suggest to force merge.

@openshift-ci openshift-ci bot added the lgtm label Aug 19, 2024
@qiujian16
Copy link
Member Author

/override codecov/project

Copy link

openshift-ci bot commented Aug 20, 2024

@qiujian16: Overrode contexts on behalf of qiujian16: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9789539 into open-cluster-management-io:main Aug 20, 2024
9 of 10 checks passed
@qiujian16 qiujian16 deleted the upgrade-go branch August 20, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants