Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s 1.29 client libs #175

Merged

Conversation

tamalsaha
Copy link
Contributor

No description provided.

client/client.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@tamalsaha tamalsaha force-pushed the k129 branch 5 times, most recently from 1729ad3 to 87783d0 Compare March 5, 2024 08:05
@xuezhaojun
Copy link
Member

/approve
The changes are in general good, the only concern is whether we can upgrade to 1.21 instead of 1.22.

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tamalsaha, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2024
@xuezhaojun
Copy link
Member

xuezhaojun commented Mar 5, 2024

Hi, @tamalsaha I noticed the PR seems mean to make cluster-proxy to work with the multicluster-controlplane.

Consulted with @skeeey, in theory it would work, but we didn't have test cases cover this case. The lib problem may not be the only issue you will encounter with.

To better trace and support this case, I created an issue under the multicluster-controlplane repo, please feel free to share any thoughts about this case.

And we are also looking forward to have you sharing in our bi-week community meeting as well!

@tamalsaha
Copy link
Contributor Author

I noticed the PR seems mean to make cluster-proxy to work with the multicluster-controlplane.

That is not the case. To support mc-cp, somethign like kluster-manager@80c0175#diff-d7b9b86f57d39143d10af42c23ca2e978eab4ec299a9288aeb44405c2de09836 will be required.

Signed-off-by: Tamal Saha <[email protected]>
@tamalsaha
Copy link
Contributor Author

Switched to Go 1.21

@xuezhaojun
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 57e29d0 into open-cluster-management-io:main Mar 5, 2024
1 check passed
@tamalsaha tamalsaha deleted the k129 branch March 5, 2024 14:14
openshift-merge-bot bot referenced this pull request in stolostron/cluster-proxy Mar 20, 2024
* Remove codecov token in actions. (#174)

Signed-off-by: xuezhaojun <[email protected]>

* Use k8s 1.29 client libs (#175)

Signed-off-by: Tamal Saha <[email protected]>

* Fix the verify error of logger. (#177)

Signed-off-by: GitHub <[email protected]>

* Upgrade chart version to 0.4.0. (#178)

Signed-off-by: GitHub <[email protected]>

* Update workflows. (#179)

Signed-off-by: GitHub <[email protected]>

* Simplify installer watchers (#180)

Signed-off-by: Tamal Saha <[email protected]>

* Remove unused code (#181)

Signed-off-by: Tamal Saha <[email protected]>

* Fix LB type proxy server setup in chart (#182)

Signed-off-by: Tamal Saha <[email protected]>

* Use default rollingout strategy. (#184)

Signed-off-by: GitHub <[email protected]>

* Add the hash value of signer into subject organizationunits (#183)

Signed-off-by: GitHub <[email protected]>

* Change examples to md format to reduce dependences. (#185)

Signed-off-by: GitHub <[email protected]>

* Update stolostronagent.

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: xuezhaojun <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Tamal Saha <[email protected]>
xuezhaojun pushed a commit to xuezhaojun/cluster-proxy that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants