Skip to content

reinstantiate header independence check in CMakeLists.txt (was commented out in the nanobind PR) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slayoo merged 2 commits into from
Jul 31, 2025
Merged

reinstantiate header independence check in CMakeLists.txt (was commented out in the nanobind PR) #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2bbb4b
reinstantiate header independence check in CMakeLists.txt (was commen…
slayoo Jul 31, 2025
b4a36b0
add Python includes; update license header
slayoo Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
####################################################################################################
# This file is a part of PyPartMC licensed under the GNU General Public License v3 (LICENSE file) #
# Copyright (C) 2022 University of Illinois Urbana-Champaign #
# Author: Sylwester Arabas #
# Copyright (C) 2022-2025 University of Illinois Urbana-Champaign #
# Author: PyPartMC developers (https://github.com/open-atmos/PyPartMC/graphs/contributors) #
####################################################################################################

cmake_minimum_required(VERSION 3.15) # CXX17
Expand Down Expand Up @@ -566,32 +566,32 @@ file(GLOB PyPartMC_headers ${CMAKE_SOURCE_DIR}/src/*.hpp)
if (NOT "${CMAKE_REQUIRED_INCLUDES}" STREQUAL "")
message("CMAKE_REQUIRED_INCLUDES not empty! (${CMAKE_REQUIRED_INCLUDES})")
endif()
# foreach(file ${PyPartMC_headers})
# set(CMAKE_REQUIRED_INCLUDES "${PYPARTMC_INCLUDE_DIRS};${pybind11_INCLUDE_DIRS}")
# set(CMAKE_REQUIRED_FLAGS "-Werror")
# string(REGEX REPLACE "[\-./:]" "_" file_var ${file})
# check_cxx_source_compiles("
# // https://github.com/nlohmann/json/issues/1408
# #if defined(_WIN32) || defined(_WIN64)
# # define HAVE_SNPRINTF
# #endif
# #include \"${file}\"
# int main() { return 0;}
# "
# _header_self_contained_${file_var}
# )
# unset(CMAKE_REQUIRED_INCLUDES)
# unset(CMAKE_REQUIRED_FLAGS)
# if (NOT _header_self_contained_${file_var})
# message(SEND_ERROR "non-self-contained header: ${file}")
# if (${CMAKE_VERSION} VERSION_LESS "3.26.0")
# file(READ "${CMAKE_BINARY_DIR}/CMakeFiles/CMakeError.log" tmp)
# else()
# file(READ "${CMAKE_BINARY_DIR}/CMakeFiles/CMakeConfigureLog.yaml" tmp)
# endif()
# message(FATAL_ERROR ${tmp})
# endif()
# unset(file_var)
# endforeach()
foreach(file ${PyPartMC_headers})
set(CMAKE_REQUIRED_INCLUDES "${PYPARTMC_INCLUDE_DIRS};${Python_INCLUDE_DIRS}")
set(CMAKE_REQUIRED_FLAGS "-Werror")
string(REGEX REPLACE "[\-./:]" "_" file_var ${file})
check_cxx_source_compiles("
// https://github.com/nlohmann/json/issues/1408
#if defined(_WIN32) || defined(_WIN64)
# define HAVE_SNPRINTF
#endif
#include \"${file}\"
int main() { return 0;}
"
_header_self_contained_${file_var}
)
unset(CMAKE_REQUIRED_INCLUDES)
unset(CMAKE_REQUIRED_FLAGS)
if (NOT _header_self_contained_${file_var})
message(SEND_ERROR "non-self-contained header: ${file}")
if (${CMAKE_VERSION} VERSION_LESS "3.26.0")
file(READ "${CMAKE_BINARY_DIR}/CMakeFiles/CMakeError.log" tmp)
else()
file(READ "${CMAKE_BINARY_DIR}/CMakeFiles/CMakeConfigureLog.yaml" tmp)
endif()
message(FATAL_ERROR ${tmp})
endif()
unset(file_var)
endforeach()

_install(TARGETS _PyPartMC LIBRARY DESTINATION PyPartMC)
Loading