-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JSON Schema for catalogs feed / catalog-entry #38
base: main
Are you sure you want to change the base?
Conversation
https://libraryregistry.librarysimplified.org/libraries => (scroll to the bottom of the page to see the JSON Schema validation errors, which are due to |
http://libraries.aldiko.com/home.json => http://readium2.herokuapp.com/opds-v2-browse/http%3A%2F%2Flibraries.aldiko.com%2Fhome.json ...for example click on the "france" https://libraries.aldiko.com/countries/france.json => (no JSON Schema errors) |
Note that Thorium does not support "catalogs" feeds yet, I filed an issue: edrlab/thorium-reader#1336 |
I have just also fixed validation errors as per AJV, see: https://github.com/ajv-validator/ajv/releases/tag/v7.0.0 |
I can write up a description of the |
@HadrienGardeur @leonardr would it be possible to finalize the spec relative to this new |
Here's a formal writeup to motivate discussion. This is very close to my current server implementation but not exactly the same (we'll be changing this soon so that won't be a problem for us). First, a summary of the
Second, a more detailed description that could, e.g. become section 1.6 of the OPDS 2.0 spec: CatalogsA Each catalog listed in a
No subcollections are required for a catalog in a Example
|
I have two specific questions:
"it MUST contain at least one collection identified by the following roles: If |
I went through the JSON Schema and updated my proposed writeup to bring the two into sync. Notably, I wrote an English definition of I have one concern about I also want to make explicit that the changes in JSON Schema imply that |
We'll implement this |
Coming back to this, I'm going to unilaterally say that I've updated my proposed spec changes to refer to the |
Ha ha! Where can I find the latest specification proposal, so I can update my PR's JSON Schema? Or are you creating your own? At any rate, I will update my copies in the micro validation service which I maintain for testing purposes. http://libraries.aldiko.com/home.json https://libraryregistry.librarysimplified.org/libraries Do you know of any other URLs which we could use for testing? PS: Thorium merely checks for the presence of the edrlab/thorium-reader#274 (comment) CC @panaC |
This JSON Schema ships in
r2-streamer-js
and has been tested with: