Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions .github/assets/check_rv32imac.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,39 +3,39 @@ set +e # Disable immediate exit on error

# Array of crates to check
crates_to_check=(
reth-codecs-derive
reth-primitives
reth-primitives-traits
reth-network-peers
reth-trie-common
reth-trie-sparse
reth-chainspec
reth-consensus
reth-consensus-common
reth-prune-types
reth-static-file-types
reth-storage-errors
reth-execution-errors
reth-errors
reth-execution-types
reth-db-models
reth-evm
reth-revm
reth-storage-api
#reth-codecs-derive
#reth-primitives
#reth-primitives-traits
#reth-network-peers
#reth-trie-common
#reth-trie-sparse
#reth-chainspec
#reth-consensus
#reth-consensus-common
#reth-prune-types
#reth-static-file-types
#reth-storage-errors
#reth-execution-errors
#reth-errors
#reth-execution-types
#reth-db-models
#reth-evm
#reth-revm
#reth-storage-api

## ethereum
reth-evm-ethereum
reth-ethereum-forks
reth-ethereum-primitives
reth-ethereum-consensus
reth-stateless
#reth-evm-ethereum
#reth-ethereum-forks
#reth-ethereum-primitives
#reth-ethereum-consensus
#reth-stateless

## optimism
reth-optimism-chainspec
reth-optimism-forks
reth-optimism-consensus
reth-optimism-primitives
reth-optimism-evm
#reth-optimism-chainspec
#reth-optimism-forks
#reth-optimism-consensus
#reth-optimism-primitives
#reth-optimism-evm
)

# Array to hold the results
Expand Down
48 changes: 48 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,24 @@ jobs:
sudo apt update && sudo apt install gcc-multilib
.github/assets/check_wasm.sh

riscv:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v6
- uses: rui314/setup-mold@v1
- uses: dtolnay/rust-toolchain@stable
with:
target: riscv32imac-unknown-none-elf
- uses: taiki-e/install-action@cargo-hack
- uses: mozilla-actions/sccache-action@v0.0.9
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- uses: dcarbone/install-jq-action@v3
- name: Run RISC-V checks
run: .github/assets/check_rv32imac.sh

crate-checks:
name: crate-checks (${{ matrix.partition }}/${{ matrix.total_partitions }})
runs-on: ubuntu-latest
Expand Down Expand Up @@ -225,6 +243,35 @@ jobs:
- name: Ensure no arbitrary or proptest dependency on default build
run: cargo tree --package reth -e=features,no-dev | grep -Eq "arbitrary|proptest" && exit 1 || exit 0

# Checks that selected crates can compile with power set of features
features:
name: features
runs-on: ubuntu-latest
strategy:
matrix:
partition: [1, 2]
total_partitions: [2]
timeout-minutes: 30
steps:
- uses: actions/checkout@v6
- uses: rui314/setup-mold@v1
- uses: dtolnay/rust-toolchain@clippy
- uses: mozilla-actions/sccache-action@v0.0.9
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- name: cargo install cargo-hack
uses: taiki-e/install-action@cargo-hack
- run: |
cargo hack check \
--all-targets \
--package reth-optimism-trie \
--package reth-optimism-exex \
--feature-powerset \
--depth 2
env:
RUSTFLAGS: -D warnings

# Check crates correctly propagate features
feature-propagation:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -260,6 +307,7 @@ jobs:
- typos
- grafana
- no-test-deps
- features
- feature-propagation
- deny
timeout-minutes: 30
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
cargo nextest run \
--features "${{ matrix.features }} $EDGE_FEATURES" --locked \
${{ matrix.exclude_args }} --workspace \
--no-tests=warn \
--exclude ef-tests --no-tests=warn \
-E "!kind(test) and not binary(e2e_testsuite)"

doc:
Expand Down
1 change: 0 additions & 1 deletion crates/optimism/exex/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ where
/// Ensure proofs storage is initialized
async fn ensure_initialized(&self) -> eyre::Result<()> {
// Check if proofs storage is initialized
#[cfg_attr(not(feature = "metrics"), expect(unused_variables))]
let earliest_block_number = match self.storage.get_earliest_block_number().await? {
Some((n, _)) => n,
None => {
Expand Down
4 changes: 3 additions & 1 deletion crates/optimism/trie/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ bincode.workspace = true
# misc
thiserror.workspace = true
auto_impl.workspace = true
eyre.workspace = true
eyre = { workspace = true, optional = true }
strum.workspace = true
tracing.workspace = true
derive_more.workspace = true
Expand All @@ -68,6 +68,7 @@ reth-testing-utils.workspace = true
reth-storage-errors.workspace = true
secp256k1.workspace = true
mockall.workspace = true
eyre.workspace = true

# misc
serial_test.workspace = true
Expand All @@ -85,4 +86,5 @@ metrics = [
"reth-trie/metrics",
"dep:reth-metrics",
"dep:metrics",
"dep:eyre",
]
Loading