-
Notifications
You must be signed in to change notification settings - Fork 10
chore: push devstack support for op-reth upstream #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| [submodule "crates/optimism/tests/optimism"] | ||
| path = crates/optimism/tests/optimism | ||
| url = https://github.com/dhyaniarun1993/optimism.git | ||
| url = https://github.com/ChainSafe/optimism.git | ||
| branch = jk/op-historical-proofs | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,22 +3,24 @@ module github.com/op-rs/op-geth | |||||
| go 1.24.0 | ||||||
|
|
||||||
| // We're using the "develop" branch of the Optimism repo to include the latest changes to the `devstack` package. | ||||||
|
||||||
| // We're using the "develop" branch of the Optimism repo to include the latest changes to the `devstack` package. | |
| // We're using the v1.16.4 release of the Optimism repo to include the desired version of the `devstack` package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states to 'remove the current submodule and replace it with optimism itself' after upstream PRs are merged, but this change points to a ChainSafe fork on a feature branch. This appears inconsistent with the stated goal of using upstream optimism. Consider clarifying whether this is an interim state or if the documentation needs updating.