Skip to content

Comments

refactor(trie): extract save_account_branches closure to method4#573

Closed
Himess wants to merge 1 commit intoop-rs:unstablefrom
Himess:refactor/backfill-save-account-branches
Closed

refactor(trie): extract save_account_branches closure to method4#573
Himess wants to merge 1 commit intoop-rs:unstablefrom
Himess:refactor/backfill-save-account-branches

Conversation

@Himess
Copy link

@Himess Himess commented Jan 10, 2026

Closes #566 (4/5)

@Himess Himess marked this pull request as draft January 10, 2026 20:29
@Himess Himess changed the title refactor(trie): extract save_account_branches closure to method refactor(trie): extract save_account_branches closure to method4 Jan 10, 2026
@Himess Himess force-pushed the refactor/backfill-save-account-branches branch from 55fdea7 to c3d3828 Compare January 10, 2026 20:38
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.39%. Comparing base (01da650) to head (c3d3828).
⚠️ Report is 5 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/optimism/trie/src/backfill.rs 90.77% <100.00%> (+0.83%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
e2e 35.79% <100.00%> (+<0.01%) ⬆️
unit 26.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 90.01% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Himess Himess marked this pull request as ready for review January 10, 2026 21:07
@dhyaniarun1993
Copy link
Collaborator

superseded by #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace closures in BackfillJob with functions

2 participants