Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
605613f
Impl ValueWithSubKey for VersionedValue
emhane Dec 10, 2025
707d022
Revert changes to runners
emhane Dec 10, 2025
7999191
Merge branch 'emhane/revert-ci-runners' into emhane/fix-missing-subke…
emhane Dec 10, 2025
cb80fe9
Merge branch 'unstable' into emhane/fix-missing-subkey-impl
dhyaniarun1993 Dec 11, 2025
f3e5a9b
chore: add prune e2e back
dhyaniarun1993 Dec 11, 2025
c73704c
chore: sysgo integration
dhyaniarun1993 Dec 11, 2025
fc1c8bd
fix code
dhyaniarun1993 Dec 11, 2025
986c6f9
Merge remote-tracking branch 'origin/emhane/fix-missing-subkey-impl' …
dhyaniarun1993 Dec 11, 2025
a076494
Merge branch 'arun/chore/add-prune-e2e' into arun/chore/sysgo-integra…
dhyaniarun1993 Dec 11, 2025
b365ba9
arun/chore/add-prune-e2e Merged
dhyaniarun1993 Dec 11, 2025
95b0c0f
fixes
dhyaniarun1993 Dec 11, 2025
1fdd712
added missing changes
dhyaniarun1993 Dec 11, 2025
b2565e3
arun/chore/add-prune-e2e Merged
dhyaniarun1993 Dec 11, 2025
c76554c
update go version
dhyaniarun1993 Dec 11, 2025
8c7d628
Update crates/optimism/tests/proofs/prune/prune_test.go
dhyaniarun1993 Dec 11, 2025
87f01b9
Apply suggestions from code review
dhyaniarun1993 Dec 11, 2025
421ee8a
unzip artifact before sysgo test
dhyaniarun1993 Dec 11, 2025
5e6ced8
arun/chore/add-prune-e2e Merged
dhyaniarun1993 Dec 11, 2025
f56c993
unstable merged + conflict resolved
dhyaniarun1993 Dec 11, 2025
6e8937d
chore: enable code coverage for e2e
dhyaniarun1993 Dec 12, 2025
c9ad73a
install-action@cargo-llvm-cov added
dhyaniarun1993 Dec 12, 2025
46e601d
fix build
dhyaniarun1993 Dec 12, 2025
af420e4
unstable merged
dhyaniarun1993 Dec 12, 2025
843c0b6
update build
dhyaniarun1993 Dec 12, 2025
19be4b6
revert build changes
dhyaniarun1993 Dec 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cov-op-historical-proof.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}
files: unit.lcov
flags: e2e
flags: unit
env_vars: OS,RUST
name: reth-op-historical-proof-unit-tests
verbose: true
Expand Down
104 changes: 40 additions & 64 deletions .github/workflows/e2e-op-historical-proof.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ jobs:
fail-fast: false
matrix:
include:
- go_pkg_name: proofs/core
- go_pkg_name: proofs/reorg
- go_pkg_name: proofs/prune
- go_pkg_name: core
- go_pkg_name: reorg
- go_pkg_name: prune

steps:
- name: Checkout
Expand All @@ -41,6 +41,8 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1

- uses: taiki-e/install-action@cargo-llvm-cov

- name: Verify tools
run: |
echo "forge: $(command -v forge || true)"
Expand All @@ -53,62 +55,24 @@ jobs:

- uses: jdx/mise-action@v3

- name: build op-reth
run: |
make build-op

# disable coverage for now
# - name: Build op-reth with coverage
# working-directory: crates/optimism/tests
# run: |
# make build-with-cov

- name: Run ${{ matrix.go_pkg_name }} e2e tests
working-directory: crates/optimism/tests
run: |
make test-e2e-sysgo GO_PKG_NAME=${{ matrix.go_pkg_name }} OP_DEVSTACK_PROOF_SEQUENCER_EL=op-geth OP_DEVSTACK_PROOF_VALIDATOR_EL=op-reth

# disable coverage for now
# - name: Flush coverage data
# working-directory: crates/optimism/tests
# run: |
# mkdir -p ./coverage
# CONTAINER=$(docker ps -aq --filter "name=op-reth" | head -n 1)
# if [ -z "$CONTAINER" ]; then
# echo "No op-reth container found"
# exit 1
# fi
# docker stop "$CONTAINER"
# sleep 5
# docker cp "$CONTAINER":/coverage .
# docker cp "$CONTAINER":/usr/local/bin/op-reth coverage/
# docker start "$CONTAINER"

# - name: Install llvm
# run: |
# sudo apt-get update
# sudo apt-get install -y llvm

# - name: Merge coverage files
# working-directory: crates/optimism/tests
# run: |
# llvm-profdata merge -sparse ./coverage/*.profraw -o ./coverage/coverage.profdata

# - name: Generate coverage report
# working-directory: crates/optimism/tests
# run: |
# llvm-cov export ./coverage/op-reth -instr-profile=./coverage/coverage.profdata -format=lcov --path-equivalence=/app/,/Users/arundhyani/Stuff/Project/chainsafe/op-reth/ -ignore-filename-regex="/rustc/|/usr/local/cargo/registry/|/target/release/build/" > ./coverage/coverage.lcov

# - name: Upload coverage to codecov.io
# uses: codecov/codecov-action@v5
# with:
# fail_ci_if_error: true
# token: ${{ secrets.CODECOV_TOKEN }}
# files: ./coverage/coverage.lcov
# flags: e2e
# env_vars: OS,RUST
# name: reth-kurtosis-tests
# verbose: true
source <(cargo llvm-cov show-env --export-prefix)
make build
make test-e2e-sysgo GO_PKG_NAME=proofs/${{ matrix.go_pkg_name }} OP_DEVSTACK_PROOF_SEQUENCER_EL=op-geth OP_DEVSTACK_PROOF_VALIDATOR_EL=op-reth
cargo llvm-cov report --lcov --output-path verifier_cov.lcov

- name: Upload coverage to codecov.io
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}
files: verifier_cov.lcov
flags: e2e
env_vars: OS,RUST
name: verifier-${{ matrix.go_pkg_name }}-sysgo-tests
verbose: true

op-reth-as-sequencer:
name: op-reth-as-sequencer-${{ matrix.go_pkg_name }}
Expand All @@ -118,9 +82,9 @@ jobs:
fail-fast: false
matrix:
include:
- go_pkg_name: proofs/core
- go_pkg_name: proofs/reorg
- go_pkg_name: proofs/prune
- go_pkg_name: core
- go_pkg_name: reorg
- go_pkg_name: prune

steps:
- name: Checkout
Expand All @@ -144,6 +108,8 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1

- uses: taiki-e/install-action@cargo-llvm-cov

- name: Verify tools
run: |
echo "forge: $(command -v forge || true)"
Expand All @@ -156,14 +122,24 @@ jobs:

- uses: jdx/mise-action@v3

- name: build op-reth
run: |
make build-op

- name: Run ${{ matrix.go_pkg_name }} e2e tests
working-directory: crates/optimism/tests
run: |
make test-e2e-sysgo GO_PKG_NAME=${{ matrix.go_pkg_name }} OP_DEVSTACK_PROOF_SEQUENCER_EL=op-reth OP_DEVSTACK_PROOF_VALIDATOR_EL=op-geth
source <(cargo llvm-cov show-env --export-prefix)
make build
make test-e2e-sysgo GO_PKG_NAME=proofs/${{ matrix.go_pkg_name }} OP_DEVSTACK_PROOF_SEQUENCER_EL=op-reth OP_DEVSTACK_PROOF_VALIDATOR_EL=op-geth
cargo llvm-cov report --lcov --output-path sequencer_cov.lcov

- name: Upload coverage to codecov.io
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}
files: sequencer_cov.lcov
flags: e2e
env_vars: OS,RUST
name: sequencer-${{ matrix.go_pkg_name }}-sysgo-tests
verbose: true

e2e-op-historical-proof-success:
name: e2e-op-historical-proof-success
Expand Down
4 changes: 2 additions & 2 deletions crates/optimism/tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ all: build-docker run
# Build op-reth
build:
@echo "Building op-reth binary..."
cd ../../../ && make build-op
cd ../../../ && cargo build --bin op-reth --manifest-path crates/optimism/bin/Cargo.toml

# Build the op-reth Docker image
build-docker:
Expand Down Expand Up @@ -81,7 +81,7 @@ test-e2e-sysgo: unzip-contract-artifacts build-contracts
export DISABLE_OP_E2E_LEGACY=true; \
export DEVSTACK_ORCHESTRATOR=sysgo; \
export OP_RETH_ENABLE_PROOF_HISTORY=true; \
export OP_RETH_EXEC_PATH="${SOURCE_DIR}/../../../target/release/op-reth"; \
export OP_RETH_EXEC_PATH="${SOURCE_DIR}/../../../target/debug/op-reth"; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkout the hive test profile

op-reth/Cargo.toml

Lines 304 to 308 in f7603f7

# Meant for testing - all optimizations, but with debug assertions and overflow checks.
[profile.hivetests]
inherits = "test"
opt-level = 3
lto = "thin"

export OP_DEVSTACK_PROOF_SEQUENCER_EL=$(OP_DEVSTACK_PROOF_SEQUENCER_EL); \
export OP_DEVSTACK_PROOF_VALIDATOR_EL=$(OP_DEVSTACK_PROOF_VALIDATOR_EL); \
go test -count=1 -timeout 40m -v ./$(GO_PKG_NAME)
Expand Down
Loading