Skip to content

fix: update metric on startup #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhyaniarun1993 merged 2 commits into from
Dec 2, 2025
Merged

fix: update metric on startup #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea27a4
fix: update metric on startup
itschaindev Dec 1, 2025
9d510a1
add metrics feature to resolve cargo check error
itschaindev Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/optimism/exex/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ reth-provider.workspace = true

# op-reth
# proofs exex handles `TrieUpdates` in notifications
reth-optimism-trie = { workspace = true, features = ["serde-bincode-compat"] }
reth-optimism-trie = { workspace = true, features = ["serde-bincode-compat", "metrics"] }

# alloy
alloy-consensus.workspace = true
Expand Down
17 changes: 12 additions & 5 deletions crates/optimism/exex/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,18 @@ where
/// Main execution loop for the ExEx
pub async fn run(mut self) -> eyre::Result<()> {
// Check if proofs storage is initialized
if self.storage.get_earliest_block_number().await?.is_none() {
return Err(eyre::eyre!(
"Proofs storage not initialized. Please run 'op-reth initialize-op-proofs --proofs-history.storage-path <PATH>' first."
));
}
let earliest_block_number = match self.storage.get_earliest_block_number().await? {
Some((n, _)) => n,
None => {
return Err(eyre::eyre!(
"Proofs storage not initialized. Please run 'op-reth initialize-op-proofs --proofs-history.storage-path <PATH>' first."
));
}
};

// Need to update the earliest block metric on startup as this is not called frequently and
// can show outdated info. When metrics are disabled, this is a no-op.
self.storage.metrics().block_metrics().earliest_number.set(earliest_block_number as f64);

let collector = LiveTrieCollector::new(
self.ctx.evm_config().clone(),
Expand Down
Loading