Ensure that block execution maintains L1 compatibility with optimism feature enabled#39
Merged
refcell merged 2 commits intoclabby/op-rethfrom Aug 3, 2023
Merged
Conversation
merklefruit
suggested changes
Aug 2, 2023
crates/revm/src/optimism.rs
Outdated
There was a problem hiding this comment.
why is this needed? where are we cloning it? Not a big deal anyway, but just want to make sure it's needed
Collaborator
Author
There was a problem hiding this comment.
Now that l1_block_info is an Optional type, the inner L1BlockInfo must be either moved or copied when it's accessed in each loop iteration.
Actually it made more sense to simply borrow the value in this context to avoid this copy
11 tasks
BrianBland
force-pushed
the
brianbland/op-executor-l1-compat
branch
from
48b0098 to
861c2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the following tests (#31):
Follow-up: Add new test cases which cover the cases where the chain has Optimism enabled