use the parameters from the optimism config in 1559 base fee computation#32
Merged
refcell merged 1 commit intoclabby/op-rethfrom Aug 2, 2023
Merged
use the parameters from the optimism config in 1559 base fee computation#32refcell merged 1 commit intoclabby/op-rethfrom
refcell merged 1 commit intoclabby/op-rethfrom
Conversation
roberto-bayardo
force-pushed
the
roberto/1559-config
branch
3 times, most recently
from
ec9c469 to
3480a51
Compare
roberto-bayardo
force-pushed
the
roberto/1559-config
branch
from
3480a51 to
b7a1b95
Compare
11 tasks
refcell
approved these changes
Aug 2, 2023
Author
|
@refcell should we roll this back as I'm upstreaming much of this? I should have probably moved this back to draft mode while I finish that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1559 base fee computation is parameterized by elasticity_muliplier and base_fee_change_denominator. Currently these values are obtained through (conditionally compiled) constants, which does not allow for them to be configured via chain config as required by optimism superchains.
This change makes all base fee computations obtain the parameter values via the ChainSpec.
addresses paradigmxyz#3750