op-reth: Fix reth-primitives signature tests#29
Merged
refcell merged 2 commits intoclabby/op-rethfrom Aug 2, 2023
Merged
Conversation
dd3b720 to
35cebd8
Compare
merklefruit
reviewed
Jul 27, 2023
11 tasks
085a4d3 to
12d4093
Compare
refcell
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates signature tests in
reth-primitivesto be compatible with the special-case optimism serialization for zero signatures (R: 0, S: 0, V: 0).Adds optimism-only test cases for this zero signature behavior
Fixes the following tests: