Skip to content

op-reth: Fix reth-primitives signature tests#29

Merged
refcell merged 2 commits intoclabby/op-rethfrom
brianbland/op-fix-sig-tests
Aug 2, 2023
Merged

op-reth: Fix reth-primitives signature tests#29
refcell merged 2 commits intoclabby/op-rethfrom
brianbland/op-fix-sig-tests

Conversation

@BrianBland
Copy link
Collaborator

@BrianBland BrianBland commented Jul 26, 2023

Updates signature tests in reth-primitives to be compatible with the special-case optimism serialization for zero signatures (R: 0, S: 0, V: 0).

Adds optimism-only test cases for this zero signature behavior

Fixes the following tests:

reth-primitives transaction::signature::tests::test_encode_and_decode_with_eip155_chain_id
reth-primitives transaction::signature::tests::test_payload_len_with_eip155_chain_id
reth-primitives transaction::signature::tests::test_v

@BrianBland BrianBland force-pushed the brianbland/op-fix-sig-tests branch from dd3b720 to 35cebd8 Compare July 26, 2023 22:25
@BrianBland BrianBland requested a review from refcell July 26, 2023 22:26
@merklefruit merklefruit mentioned this pull request Jul 30, 2023
11 tasks
@BrianBland BrianBland force-pushed the brianbland/op-fix-sig-tests branch from 085a4d3 to 12d4093 Compare July 31, 2023 22:07
@refcell refcell merged commit 1a996e7 into clabby/op-reth Aug 2, 2023
@emhane emhane deleted the brianbland/op-fix-sig-tests branch September 25, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants