Conversation
dhyaniarun1993
added
K-feature
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
dhyaniarun1993
requested review from
BioMark3r,
emhane,
itschaindev,
meyer9,
sadiq1971 and
theochap
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces MDBX storage support for external proofs by implementing new database models and reorganizing the storage module structure.
- Adds comprehensive MDBX table definitions for versioned trie data storage
- Creates new models for storage keys, versioning, and database compression/decompression
- Reorganizes storage module structure to separate in-memory and MDBX implementations
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/exex/external-proofs/src/storage/mod.rs | Creates new storage module structure with trait exports and submodule declarations |
| crates/exex/external-proofs/src/storage/mdbx/models/version.rs | Implements version wrappers for optional values and versioned storage with compression support |
| crates/exex/external-proofs/src/storage/mdbx/models/storage.rs | Defines composite keys for storage trie indexing and proof window tracking |
| crates/exex/external-proofs/src/storage/mdbx/models/mod.rs | Declares MDBX table schemas for historical trie and account data storage |
| crates/exex/external-proofs/src/storage/mdbx/models/block.rs | Implements block number and hash wrapper with database serialization |
| crates/exex/external-proofs/src/storage/mdbx/mod.rs | Creates MDBX module entry point with model exports |
| crates/exex/external-proofs/src/storage/in_memory/store_tests.rs | Updates import path to use reorganized storage module |
| crates/exex/external-proofs/src/storage/in_memory/store.rs | Updates import paths and removes duplicated documentation |
| crates/exex/external-proofs/src/storage/in_memory/mod.rs | Creates in-memory storage module with proper documentation |
| crates/exex/external-proofs/src/lib.rs | Updates imports to use new storage module structure |
| crates/exex/external-proofs/src/backfill.rs | Updates import paths for reorganized storage |
| crates/exex/external-proofs/Cargo.toml | Adds bytes crate dependency for buffer operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sadiq1971
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #209