Introduce parameterized basefee calculation method to fix op tests#21
Closed
BrianBland wants to merge 1 commit intoclabby/op-rethfrom
Closed
Introduce parameterized basefee calculation method to fix op tests#21BrianBland wants to merge 1 commit intoclabby/op-rethfrom
BrianBland wants to merge 1 commit intoclabby/op-rethfrom
Conversation
Collaborator
Author
|
Closing in favor of #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new
calculate_next_block_base_fee_with_block_paramsmethod to compute the new base fee given an elasticity multiplier and max change denominator, and call this with the defined constants from the pre-existingcalculate_next_block_base_feemethod.This allows us to pass in custom EIP-1559 constants for testing/other purposes, which is particularly relevant to building with the
optimismfeature enabled, which modifies these constants and causes the computed values to differ from the expected test cases.