feat: create initial external-proofs ExEx crate#181
Conversation
255c999 to
f2f2fe2
Compare
f1ddffd to
a24510a
Compare
e1801e2 to
d728795
Compare
d728795 to
b5d8c02
Compare
There was a problem hiding this comment.
Pull Request Overview
Creates a new ExEx (Execution Extension) crate for external proof handling that processes blocks and tracks state changes to optimize proof generation.
- Introduces a new
external-proofsExEx crate with basic structure and execution loop - Adds the new crate to the workspace members
- Implements foundational components for tracking committed chains and notifying completion
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/exex/external-proofs/src/lib.rs | Main implementation of the ExternalProofExEx struct with initialization and execution loop |
| crates/exex/external-proofs/Cargo.toml | Package configuration and dependencies for the external-proofs crate |
| Cargo.toml | Adds external-proofs crate to workspace members |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // match ¬ification { | ||
| // _ => {} | ||
| // }; |
There was a problem hiding this comment.
Remove commented-out code. If this is intended as a placeholder for future implementation, consider adding a TODO comment with more specific context about what notification handling will be added.
| // match ¬ification { | |
| // _ => {} | |
| // }; | |
| // TODO: Implement notification handling logic here as needed. |
| impl<Node, Primitives> ExternalProofExEx<Node> | ||
| where | ||
| Node: FullNodeComponents<Types: NodeTypes<Primitives = Primitives>>, | ||
| Primitives: NodePrimitives, |
There was a problem hiding this comment.
The Primitives generic parameter is unused in the implementation. Since Node::Provider: StateReader is already constrained in the struct definition, consider removing the unused Primitives parameter or add a comment explaining why it will be needed for future functionality.
| impl<Node, Primitives> ExternalProofExEx<Node> | |
| where | |
| Node: FullNodeComponents<Types: NodeTypes<Primitives = Primitives>>, | |
| Primitives: NodePrimitives, | |
| impl<Node> ExternalProofExEx<Node> | |
| where | |
| Node: FullNodeComponents, | |
| Node::Provider: StateReader, |
|
Link issues aren't related to the PR itself. Merging the PR. |
Fixes #165