Skip to content

Comments

feat: create initial external-proofs ExEx crate#181

Merged
dhyaniarun1993 merged 1 commit intounstablefrom
meyer9/165-add-empty-exex-crate
Sep 30, 2025
Merged

feat: create initial external-proofs ExEx crate#181
dhyaniarun1993 merged 1 commit intounstablefrom
meyer9/165-add-empty-exex-crate

Conversation

@meyer9
Copy link
Collaborator

@meyer9 meyer9 commented Sep 25, 2025

Fixes #165

@github-actions github-actions bot added the W-historical-proofs Workstream: historical-proofs label Sep 25, 2025
@meyer9 meyer9 force-pushed the meyer9/165-add-empty-exex-crate branch from 255c999 to f2f2fe2 Compare September 25, 2025 20:16
@meyer9 meyer9 marked this pull request as ready for review September 25, 2025 20:16
@meyer9 meyer9 force-pushed the meyer9/165-add-empty-exex-crate branch 2 times, most recently from f1ddffd to a24510a Compare September 25, 2025 20:17
@meyer9 meyer9 linked an issue Sep 25, 2025 that may be closed by this pull request
@meyer9 meyer9 marked this pull request as draft September 25, 2025 20:51
@meyer9 meyer9 force-pushed the meyer9/165-add-empty-exex-crate branch 2 times, most recently from e1801e2 to d728795 Compare September 25, 2025 21:03
@meyer9 meyer9 marked this pull request as ready for review September 26, 2025 15:15
@dhyaniarun1993 dhyaniarun1993 changed the base branch from main to unstable September 29, 2025 12:35
Copilot AI review requested due to automatic review settings September 29, 2025 16:13
@meyer9 meyer9 force-pushed the meyer9/165-add-empty-exex-crate branch from d728795 to b5d8c02 Compare September 29, 2025 16:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Creates a new ExEx (Execution Extension) crate for external proof handling that processes blocks and tracks state changes to optimize proof generation.

  • Introduces a new external-proofs ExEx crate with basic structure and execution loop
  • Adds the new crate to the workspace members
  • Implements foundational components for tracking committed chains and notifying completion

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
crates/exex/external-proofs/src/lib.rs Main implementation of the ExternalProofExEx struct with initialization and execution loop
crates/exex/external-proofs/Cargo.toml Package configuration and dependencies for the external-proofs crate
Cargo.toml Adds external-proofs crate to workspace members

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +35 to +37
// match &notification {
// _ => {}
// };
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code. If this is intended as a placeholder for future implementation, consider adding a TODO comment with more specific context about what notification handling will be added.

Suggested change
// match &notification {
// _ => {}
// };
// TODO: Implement notification handling logic here as needed.

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +25
impl<Node, Primitives> ExternalProofExEx<Node>
where
Node: FullNodeComponents<Types: NodeTypes<Primitives = Primitives>>,
Primitives: NodePrimitives,
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Primitives generic parameter is unused in the implementation. Since Node::Provider: StateReader is already constrained in the struct definition, consider removing the unused Primitives parameter or add a comment explaining why it will be needed for future functionality.

Suggested change
impl<Node, Primitives> ExternalProofExEx<Node>
where
Node: FullNodeComponents<Types: NodeTypes<Primitives = Primitives>>,
Primitives: NodePrimitives,
impl<Node> ExternalProofExEx<Node>
where
Node: FullNodeComponents,
Node::Provider: StateReader,

Copilot uses AI. Check for mistakes.
@dhyaniarun1993
Copy link
Collaborator

Link issues aren't related to the PR itself. Merging the PR.

@dhyaniarun1993 dhyaniarun1993 merged commit 19f3a51 into unstable Sep 30, 2025
78 of 129 checks passed
@dhyaniarun1993 dhyaniarun1993 deleted the meyer9/165-add-empty-exex-crate branch September 30, 2025 10:29
emhane pushed a commit that referenced this pull request Oct 20, 2025
meyer9 added a commit that referenced this pull request Oct 31, 2025
emhane pushed a commit that referenced this pull request Nov 11, 2025
meyer9 added a commit that referenced this pull request Nov 13, 2025
emhane pushed a commit that referenced this pull request Nov 18, 2025
emhane pushed a commit that referenced this pull request Nov 25, 2025
emhane pushed a commit that referenced this pull request Dec 8, 2025
emhane pushed a commit that referenced this pull request Dec 10, 2025
emhane pushed a commit that referenced this pull request Dec 18, 2025
emhane pushed a commit that referenced this pull request Dec 18, 2025
emhane pushed a commit that referenced this pull request Jan 5, 2026
emhane pushed a commit that referenced this pull request Jan 13, 2026
emhane pushed a commit that referenced this pull request Jan 15, 2026
emhane pushed a commit that referenced this pull request Jan 20, 2026
emhane pushed a commit that referenced this pull request Jan 26, 2026
emhane pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

W-historical-proofs Workstream: historical-proofs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create empty ExEx crate for historical proofs

2 participants