[tracking] Fix broken tests by merklefruit · Pull Request #11 · op-rs/op-reth

merklefruit · 2023-07-12T17:36:28Z

Current test status:

     Summary [  25.235s] 1159 tests run: 1147 passed, 12 failed, 15 skipped
        FAIL [   0.068s] reth-consensus-common validation::tests::sanity_check
        FAIL [   0.481s] reth-eth-wire types::receipts::ReceiptsTests::proptest
        FAIL [   0.006s] reth-primitives basefee::tests::calculate_base_fee_success
        FAIL [   0.006s] reth-primitives transaction::signature::tests::test_encode_and_decode_with_eip155_chain_id
        FAIL [   0.006s] reth-primitives transaction::signature::tests::test_payload_len_with_eip155_chain_id
        FAIL [   0.006s] reth-primitives transaction::signature::tests::test_v
        FAIL [   0.101s] reth-revm executor::tests::sanity_execution
        FAIL [   0.058s] reth-revm executor::tests::test_selfdestruct
        FAIL [   0.091s] reth-stages stages::execution::tests::sanity_execute_unwind
        FAIL [   0.094s] reth-stages stages::execution::tests::sanity_execution_of_block
        FAIL [   0.085s] reth-stages stages::execution::tests::test_prune
        FAIL [   0.094s] reth-stages stages::execution::tests::test_selfdestruct

Remove `consensus` crate `Cargo.toml` Reduce diff

…minator

… vaults

Remove `consensus` crate `Cargo.toml` Reduce diff

x

Signed-off-by: Brian Bland <brian.t.bland@gmail.com>

…ruit/fix-tests

merklefruit · 2023-07-28T10:34:16Z

closed in favor of #31

Resolution checkpoint Resolution checkpoint #2 Resolution checkpoint #3 x Resolution checkpoint #4 Resolution checkpoint #5 Resolution checkpoint #6 Resolution checkpoint #7 Resolution checkpoint #8 Resolve checkpoint #9 (transaction primitive) Resolve checkpoint #10 (rpc api transactions) Resolve checkpoint #11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>

rkrasiuk and others added 30 commits July 9, 2023 14:08

feat: deposit tx

1afa8e9

chainspec and forks

f9a1111

feat: payload attributes op fields

009d1f0

small fixes

8b8db55

Small changes to the deposit tx primitive

64b0868

more small fixes

09706b0

compiles

9c78320

Move feature flags below comments

8f7641b

Doc auto link

815f32b

WIP: OP Goerli genesis

00b997a

Signature fix

acca206

TEMP: Expose some CLI items

d5398fa

Resolve conflicts

b8530c9

Remove `consensus` crate `Cargo.toml` Reduce diff

Allow gaslimit to be set by the EngineAPI caller on OP

d418af6

Add Optimism EIP1559 elasticity multiplier / max base fee change deno…

90af976

…minator

feat: executor deposits

3eedcd5

feat: receipts, l1 cost wip

7bfd16b

chore: small fixes

719eaca

wip: transact() optimism changes

d0fb3e1

chore: minor changes related to optimism execution

77556da

wip: removed receipts changes + improved gas handling

9bf7165

chore: cleanup

b6e0704

chore: system_tx and is_success method

8f8ae04

feat: refactoring: separated optimism feature + added routing fees to…

96d5249

… vaults

fix: fee vault calc

c9fc38b

fix: increment balance via executor function

50ecb2a

chore: minor fixes

06954f3

feat: parse l1 block info from l2 block

a04cc8d

chore: removed default trait

4868a52

chore: set deposit gas to 0 always

08daf5b

clabby and others added 15 commits July 22, 2023 11:14

Small changes to the deposit tx primitive

0c69e20

more small fixes

4b99875

compiles

53f850a

Move feature flags below comments

0a2301f

WIP: OP Goerli genesis

a4e54c6

TEMP: Expose some CLI items

9840c12

Resolve conflicts

168846b

Remove `consensus` crate `Cargo.toml` Reduce diff

feat: executor deposits

70bbdb1

feat: receipts, l1 cost wip

fc97260

chore: small fixes

2544de4

wip: transact() optimism changes

1cc1e71

wip: removed receipts changes + improved gas handling

651731e

chore: cleanup

a7aef80

chore: system_tx and is_success method

3c5ee55

chore: minor fixes

a1fe33c

refcell force-pushed the clabby/op-reth branch from 108e0d1 to 0f94918 Compare July 26, 2023 17:08

clabby and others added 8 commits July 26, 2023 19:51

Start resolving conflicts

7212a78

More conflict resolution / updates

57824e2

x

fix build failures with optimism feature

17f771e

Fix feature flag

9669a1c

Use TTD(0) fork condition for OP_GOERLI Paris hardfork

632d1bf

Signed-off-by: Brian Bland <brian.t.bland@gmail.com>

chore: merge conflicts

0bdbd76

chore: fix merge conflicts

a9a84c5

Merge branch 'clabby/op-reth' of github.com:refcell/reth into merklef…

cd19537

…ruit/fix-tests

merklefruit closed this Jul 28, 2023

clabby added a commit that referenced this pull request Aug 12, 2023

Resolve checkpoint #11 (building w/o feature flag)

f398927

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tracking] Fix broken tests#11

[tracking] Fix broken tests#11
merklefruit wants to merge 153 commits intoop-rs:clabby/op-rethfrom
merklefruit:merklefruit/fix-tests

merklefruit commented Jul 12, 2023 •

edited

Loading

Uh oh!

merklefruit commented Jul 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

merklefruit commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merklefruit commented Jul 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

merklefruit commented Jul 12, 2023 •

edited

Loading