Skip to content

Small changes to the deposit tx primitive#1

Merged
refcell merged 1 commit intoop-rs:refcell/compilingfrom
clabby:clabby/optimism/deposit-tx
Feb 27, 2023
Merged

Small changes to the deposit tx primitive#1
refcell merged 1 commit intoop-rs:refcell/compilingfrom
clabby:clabby/optimism/deposit-tx

Conversation

@clabby
Copy link

@clabby clabby commented Feb 27, 2023

Overview

Small changes to the deposit transaction primitive:

  • Deposit transactions don't have nonces; This value always defaults to 0.
  • Add getters for source_hash, mint, & is_system_transaction that may be enabled by the optimism feature flag.
  • Temporarily panic when encoding a deposit transaction with a non-zero signature. We should handle this higher up, panicking here isn't the right move.

@refcell refcell merged commit 4b8ee66 into op-rs:refcell/compiling Feb 27, 2023
clabby added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants