Skip to content
This repository was archived by the owner on Feb 21, 2025. It is now read-only.

feat(protocol): Operator Fee#10

Merged
refcell merged 1 commit intomainfrom
rf/isthmus-operator-fee
Feb 4, 2025
Merged

feat(protocol): Operator Fee#10
refcell merged 1 commit intomainfrom
rf/isthmus-operator-fee

Conversation

@refcell
Copy link
Copy Markdown
Contributor

@refcell refcell commented Jan 8, 2025

Description

Defines L1BlockInfoIsthmus in maili-protocol to include the new operator fee scalar and operator fee constant.

Original PR in op-alloy: alloy-rs/op-alloy#130

Additional Context

Design Doc
Spec.

@refcell
Copy link
Copy Markdown
Contributor Author

refcell commented Jan 8, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from mattsse as a code owner January 8, 2025 18:42
@refcell refcell self-assigned this Jan 8, 2025
@refcell refcell requested review from clabby and emhane as code owners January 8, 2025 18:42
@refcell refcell added A-protocol Area: protocol crate C-feat Category: new feature or request C-hardfork labels Jan 8, 2025
@emhane emhane added the C-blocked Category: cannot move forward until something else changes label Jan 8, 2025
@emhane
Copy link
Copy Markdown
Contributor

emhane commented Jan 8, 2025

blocked until spec is merged ethereum-optimism/specs#382

@refcell refcell marked this pull request as draft January 13, 2025 15:25
@refcell
Copy link
Copy Markdown
Contributor Author

refcell commented Jan 13, 2025

Aaaand back on ice

@emhane emhane removed the C-hardfork label Jan 15, 2025
@refcell refcell changed the title feat(protocol): Isthmus Operator Fee feat(protocol): Operator Fee Feb 2, 2025
@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 401e12c to d318194 Compare February 3, 2025 19:40
@refcell refcell marked this pull request as ready for review February 3, 2025 19:40
@refcell refcell removed the C-blocked Category: cannot move forward until something else changes label Feb 3, 2025
Copy link
Copy Markdown
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me per the spec. Would be nice to get a double-check from the succinct team, but no need to block on it.

@refcell
Copy link
Copy Markdown
Contributor Author

refcell commented Feb 4, 2025

Network Upgrade Transactions (for posterity): alloy-rs/op-alloy#411

@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 7a8e500 to 966f4cc Compare February 4, 2025 12:01
@refcell refcell force-pushed the rf/isthmus-operator-fee branch from 966f4cc to d9bb360 Compare February 4, 2025 12:04
@refcell refcell requested a review from leruaa February 4, 2025 12:05
Copy link
Copy Markdown

@leruaa leruaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refcell refcell merged commit e484275 into main Feb 4, 2025
21 checks passed
@refcell refcell deleted the rf/isthmus-operator-fee branch February 4, 2025 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-protocol Area: protocol crate C-feat Category: new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants