Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore: De-duplicate SpecId Helper#979

Merged
refcell merged 4 commits intomaili-updatefrom
rf/de-dup-spec-id
Jan 30, 2025
Merged

chore: De-duplicate SpecId Helper#979
refcell merged 4 commits intomaili-updatefrom
rf/de-dup-spec-id

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 30, 2025

Description

De-duplicates the spec id helper.

Closes #971

@refcell refcell self-assigned this Jan 30, 2025
@refcell refcell requested review from clabby and emhane as code owners January 30, 2025 00:20
@refcell
Copy link
Contributor Author

refcell commented Jan 30, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell mentioned this pull request Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.8%. Comparing base (d61a45a) to head (da00632).
Report is 1 commits behind head on maili-update.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/mpt/src/list_walker.rs 0.0% 1 Missing ⚠️
crates/proof-sdk/std-fpvm/src/channel.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby
Copy link
Contributor

clabby commented Jan 30, 2025

Is the revm dependency in maili disabling default features? Looks to be failing on the no_std builds.

@refcell refcell merged commit 6ae5f0e into maili-update Jan 30, 2025
15 of 16 checks passed
@refcell refcell deleted the rf/de-dup-spec-id branch January 30, 2025 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants