Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(executor): Withdrawals root#974

Merged
refcell merged 1 commit intomainfrom
cl/wd-root-fix
Jan 29, 2025
Merged

fix(executor): Withdrawals root#974
refcell merged 1 commit intomainfrom
cl/wd-root-fix

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Jan 29, 2025

Overview

Fixes the withdrawals root feature of Isthmus. It's not currently enabled, but there was also a logic flaw where it fetched the L2ToL1MessagePasser's storage root for the parent block, not the current block.

@clabby clabby added K-fix Kind: fix A-protocol Area: protocol crates W-isthmus Workstream: Isthmus labels Jan 29, 2025
@clabby clabby self-assigned this Jan 29, 2025
@clabby clabby requested review from emhane and refcell as code owners January 29, 2025 15:09
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.8%. Comparing base (b3ce5ee) to head (c5c62fa).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/executor/mod.rs 11.1% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clabby
Copy link
Contributor Author

clabby commented Jan 29, 2025

btw

the trieaccount looks identical to

https://github.com/alloy-rs/trie/blob/main/src/account.rs

Nice. We'll de-dup that.

@clabby
Copy link
Contributor Author

clabby commented Jan 29, 2025

@mattsse #975

@refcell refcell merged commit 01aba48 into main Jan 29, 2025
15 of 16 checks passed
@refcell refcell deleted the cl/wd-root-fix branch January 29, 2025 15:27
This was referenced Jan 29, 2025
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-protocol Area: protocol crates K-fix Kind: fix W-isthmus Workstream: Isthmus

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants