Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(executor): Update SpecId with Isthmus#962

Merged
refcell merged 1 commit intomainfrom
rf/env-update
Jan 28, 2025
Merged

chore(executor): Update SpecId with Isthmus#962
refcell merged 1 commit intomainfrom
rf/env-update

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 28, 2025

Description

Updates the revm SpecId with Isthmus.

Closes #947.

@refcell refcell requested a review from clabby as a code owner January 28, 2025 16:45
@refcell refcell self-assigned this Jan 28, 2025
@refcell refcell requested a review from emhane as a code owner January 28, 2025 16:45
@refcell
Copy link
Contributor Author

refcell commented Jan 28, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.8%. Comparing base (c017eea) to head (b105404).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/executor/env.rs 66.6% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emhane
Copy link
Contributor

emhane commented Jan 28, 2025

this code appears duplicate in op-reth, perhaps would be nice to move into maili to avoid having to update in two places

@refcell
Copy link
Contributor Author

refcell commented Jan 28, 2025

this code appears duplicate in op-reth, perhaps would be nice to move into maili to avoid having to update in two places

Agreed. Let's write up a ticket to track

@refcell refcell merged commit 4e5325b into main Jan 28, 2025
15 of 16 checks passed
@refcell refcell deleted the rf/env-update branch January 28, 2025 18:30
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
This was referenced Feb 5, 2025
byteflyfunny pushed a commit to mantle-xyz/kona that referenced this pull request Feb 13, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

dep(workspace): Upgrade + integrate revm with Isthmus support

2 participants