Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Bump revm to 19.3.0#901

Closed
sergerad wants to merge 3 commits intoop-rs:mainfrom
sergerad:sergerad/revm-bump
Closed

Bump revm to 19.3.0#901
sergerad wants to merge 3 commits intoop-rs:mainfrom
sergerad:sergerad/revm-bump

Conversation

@sergerad
Copy link
Contributor

WIP

Closes #898

@sergerad sergerad changed the title Bump revm to 19.2.0 and fix compilation Bump revm to 19.2.0 Jan 14, 2025
@sergerad sergerad changed the title Bump revm to 19.2.0 Bump revm to 19.3.0 Jan 14, 2025
@sergerad
Copy link
Contributor Author

@clabby the changes in revm appear to invalidate some of the preimages used for testing e.g.

──── STDERR:             kona-executor executor::test::test_l2_block_executor_big_block
thread 'executor::test::test_l2_block_executor_big_block' panicked at crates/executor/src/executor/mod.rs:852:80:
called `Result::unwrap()` on an `Err` value: ExecutionError(Database(TrieNode(Provider("Preimage not found for key: 0xba2c4f074c9e55148193c1890e39d43558096de038d7a2388c45c98cb7958889"))))

Do the precomputed values in crates/executor/testdata/block_* need to be regenerated?

@clabby
Copy link
Contributor

clabby commented Jan 17, 2025

@clabby the changes in revm appear to invalidate some of the preimages used for testing e.g.

──── STDERR:             kona-executor executor::test::test_l2_block_executor_big_block
thread 'executor::test::test_l2_block_executor_big_block' panicked at crates/executor/src/executor/mod.rs:852:80:
called `Result::unwrap()` on an `Err` value: ExecutionError(Database(TrieNode(Provider("Preimage not found for key: 0xba2c4f074c9e55148193c1890e39d43558096de038d7a2388c45c98cb7958889"))))

Do the precomputed values in crates/executor/testdata/block_* need to be regenerated?

Yeah they do. I've gone ahead and done this in #910 as I needed it - for future reference, these can be generated by running the client/host program natively w/ the just directives here. A bit annoying for the average user due to the node requirements, though 😅

Will go ahead and close this, but thank you for bumping this!

@clabby clabby closed this Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bump revm version to ^v19.1.0 to include Isthmus operator fee feature

2 participants