feat(build): Adjust RV target - riscv64g -> riscv64ima

[clabby]

Overview

Note

I validated locally that this target works out fine for running on asterisc, but will need to cut a release of the asterisc-builder cross compilation image for this to pass CI. Will do after vaca.

For anyone who wants to experiment with this, head over to the build dir, and build the asterisc image locally w/ just asterisc. Then, head over to the root justfile, and adjust the build-asterisc recipe to use the local asterisc-pipeline:latest image that was built in the previous step.

Once this is done, head over to bin/client, and run kona on asterisc w/ just run-client-asterisc to use the new riscv64ima binary.

e: A new image was manually published. This is good to go.

Adjusts the build pipeline to use riscv64imac-unknown-none-elf as the target rather than riscv64gc. We still turn off compressed instructions, but this target forces LLVM to use soft-float operations for any floating point / doubleword floating point operations.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.6%. Comparing base (f2b634f) to head (67e9df7).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zigtur]

I wonder if there is a way to exclude Zicsr instructions from the build.

The LLVM docs are unclear about it:

zicntr, zicsr, zifencei, zihpm
Between versions 2.0 and 2.1 of the base I specification, a backwards incompatible change was made to remove selected instructions and CSRs from the base ISA. These instructions were grouped into a set of new extensions, but were no longer required by the base ISA. This change is partially described in “Preface to Document Version 20190608-Base-Ratified” from the specification document (the zicntr and zihpm bits are not mentioned). LLVM currently implements version 2.1 of the base specification. To maintain compatibility, instructions from these extensions are accepted without being in the -march string. LLVM also allows the explicit specification of the extensions in an -march string.

It would make sense to also exclude these instructions as they are not supported by Asterisc.

[clabby]

I wonder if there is a way to exclude Zicsr instructions from the build.

The LLVM docs are unclear about it:

zicntr, zicsr, zifencei, zihpm
Between versions 2.0 and 2.1 of the base I specification, a backwards incompatible change was made to remove selected instructions and CSRs from the base ISA. These instructions were grouped into a set of new extensions, but were no longer required by the base ISA. This change is partially described in “Preface to Document Version 20190608-Base-Ratified” from the specification document (the zicntr and zihpm bits are not mentioned). LLVM currently implements version 2.1 of the base specification. To maintain compatibility, instructions from these extensions are accepted without being in the -march string. LLVM also allows the explicit specification of the extensions in an -march string.

It would make sense to also exclude these instructions as they are not supported by Asterisc.

Yep, can turn these off. Note that rustc doesn't directly support these codegen options, but it does allow for fall-through directives to LLVM. We get a few warnings in the build, though from the rust forums this looks to be expected. Can validate that these features exist w/ rustc --target=riscv64imac-unknown-none-elf -Ctarget-feature=help