Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(mpt): Empty root node case#705

Merged
refcell merged 1 commit intomainfrom
cl/empty-mpt-root
Oct 18, 2024
Merged

fix(mpt): Empty root node case#705
refcell merged 1 commit intomainfrom
cl/empty-mpt-root

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Oct 18, 2024

Overview

Adds coverage for the case where the root node of an MPT is the empty root hash. The previous behavior could cause a bug if an account storage root was cleared out entirely from a previously populated value during the execution of a block.

This ensures that, if the root is empty, the empty root hash is returned by blinded_commitment.

closes #704

@clabby clabby added K-fix Kind: fix A-mpt labels Oct 18, 2024
@clabby clabby self-assigned this Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (6b6a881) to head (04a307a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review October 18, 2024 16:20
@clabby clabby requested a review from refcell as a code owner October 18, 2024 16:20
@refcell refcell added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 7d22a13 Oct 18, 2024
@clabby clabby deleted the cl/empty-mpt-root branch October 18, 2024 16:45
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-fix Kind: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mpt): Empty root node

2 participants