This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(derive): SpanBatch element limit + channel RLP size limit#692
Merged
fix(derive): SpanBatch element limit + channel RLP size limit#692
Conversation
clabby
force-pushed
the
cl/span-batch-fix
branch
3 times, most recently
from
94daf0f to
0815d0f
Compare
clabby
force-pushed
the
cl/span-batch-fix
branch
from
0815d0f to
7b60fd9
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
reviewed
Oct 15, 2024
refcell
approved these changes
Oct 15, 2024
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Generally happy with this as it removes a bunch of hardfork-specific logic. Really think this demonstrates the need to upstream logic into op-alloy
Closed
refcell
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(derive): SpanBatch element limit + channel RLP size limit * remove unused fn * channel reader fjord test
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…kona#692) * fix(derive): SpanBatch element limit + channel RLP size limit * remove unused fn * channel reader fjord test
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…kona#692) * fix(derive): SpanBatch element limit + channel RLP size limit * remove unused fn * channel reader fjord test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The enforcements on span batch size for Fjord was implemented incorrectly. There is a separate protocol constant,
MaxSpanBatchElements, in the reference implementation that limits span batch element size. This is strictly different than the channel size limitation.We also did not enforce maximum channel RLP size within the
BatchReaderfor zlib. This has been fixed.