Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(primitives): Remove Attributes#529

Merged
refcell merged 2 commits intomainfrom
rf/feat/payload-reuse
Sep 17, 2024
Merged

feat(primitives): Remove Attributes#529
refcell merged 2 commits intomainfrom
rf/feat/payload-reuse

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Sep 16, 2024

Description

Removes the attributes module from kona-primitives, re-using payload attributes types defined in alloy-rpc-types-engine and op-alloy-rpc-types-engine.

Closes #510

@refcell refcell changed the title feat: remove attributes feat(primitives): Remove Attributes Sep 16, 2024
Copy link
Contributor Author

refcell commented Sep 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby September 16, 2024 20:20
@refcell refcell added A-primitives K-chore Kind: chore labels Sep 16, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 16, 2024 20:20
@refcell refcell self-assigned this Sep 16, 2024
@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 97.75785% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.9%. Comparing base (f639744) to head (7f3ade4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/derive/src/stages/attributes_queue.rs 94.5% 2 Missing ⚠️
crates/executor/src/lib.rs 98.4% 2 Missing ⚠️
crates/derive/src/pipeline/core.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd prefer if we changed OptimismPayloadAttributes to not have Options for transactions, no_tx_pool. These should always be there, since the type is not intended to be backwards-compat w/ L1 payload attributes.

@refcell
Copy link
Contributor Author

refcell commented Sep 16, 2024

Looks good, but I'd prefer if we changed OptimismPayloadAttributes to not have Options for transactions, no_tx_pool. These should always be there, since the type is not intended to be backwards-compat w/ L1 payload attributes.

They're all marked omitempty in the reference implementation: https://github.com/ethereum-optimism/optimism/blob/8dd6fb36aad7a1cd5c9e7e877b340b2e0c5cc14c/op-service/eth/types.go#L326-L331

Do you want to diverge from this for any specific reason?

@refcell refcell requested a review from clabby September 16, 2024 23:36
@refcell refcell force-pushed the rf/feat/payload-reuse branch from b1ef0f9 to aa69a8d Compare September 17, 2024 13:56
@refcell refcell changed the base branch from rf/feat/large-dep-update to main September 17, 2024 13:56
@refcell refcell added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit f79724c Sep 17, 2024
This was referenced Sep 17, 2024
This was referenced Sep 27, 2024
This was referenced Oct 5, 2024
This was referenced Oct 9, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
* feat: remove attributes

* fixes
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
* feat: remove attributes

* fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

K-chore Kind: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(primitives): Remove Attributes Module

2 participants