Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

test(derive): Channel timeout#437

Merged
clabby merged 1 commit intomainfrom
cl/channel-timeout-test
Aug 21, 2024
Merged

test(derive): Channel timeout#437
clabby merged 1 commit intomainfrom
cl/channel-timeout-test

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Aug 21, 2024

Overview

Adds a test to the channel bank for channel timeout on OP mainnet & Base Mainnet rollup configs.

@clabby clabby mentioned this pull request Aug 21, 2024
Merged
@clabby Graphite App
Copy link
Contributor Author

clabby commented Aug 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Aug 21, 2024
Merged
@clabby clabby self-assigned this Aug 21, 2024
@clabby clabby added A-proof Area: proof crates M-tests Meta: Testing related labels Aug 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (7cc7a22) to head (d7484f2).

Files Patch % Lines
crates/derive/src/stages/channel_bank.rs 93.4% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refcell
refcell approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@clabby clabby force-pushed the cl/remove-warning branch from 631f3f1 to 1489781 Compare August 21, 2024 14:21
@clabby clabby force-pushed the cl/channel-timeout-test branch from 2ea0c7b to 7dfee7d Compare August 21, 2024 14:21
@clabby clabby force-pushed the cl/remove-warning branch from 1489781 to 08cd225 Compare August 21, 2024 14:22
@clabby clabby force-pushed the cl/channel-timeout-test branch from 7dfee7d to 8085dd7 Compare August 21, 2024 14:22
@clabby clabby force-pushed the cl/channel-timeout-test branch from 8085dd7 to d7484f2 Compare August 21, 2024 15:45
@clabby clabby changed the base branch from cl/remove-warning to main August 21, 2024 15:45
@clabby clabby added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit d654986 Aug 21, 2024
@github-actions github-actions bot mentioned this pull request Aug 21, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@clabby
test(derive): Channel timeout (op-rs/kona#437)
e95aa33
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@clabby
test(derive): Channel timeout (op-rs/kona#437)
310db2d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@refcell refcell refcell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clabby clabby

Labels

A-proof Area: proof crates M-tests Meta: Testing related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clabby @codecov-commenter @refcell