Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix(ci): reduce ci usage by only running jobs on merge group #3194

Merged
theochap merged 1 commit into from
Dec 15, 2025
Merged

fix(ci): reduce ci usage by only running jobs on merge group #3194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/acceptance-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Acceptance Tests
on:
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the pull_request trigger means these critical tests will not run on pull requests at all. This creates a significant workflow issue:

  1. Developers won't see test results during PR review
  2. Test failures will only be discovered in the merge queue, not during development
  3. This delays feedback and can block the merge queue with failing PRs

If the goal is to reduce CI usage, consider alternative approaches:

  • Use path filters to only run tests when relevant files change
  • Use conditional logic based on labels (e.g., only run on PRs labeled "ready-for-review")
  • Use workflow_run to trigger only after other checks pass
  • Keep pull_request but add conditions to skip on draft PRs

Completely removing pull_request triggers from test workflows is likely to cause more problems than it solves.

Suggested change
on:
on:
pull_request:

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the push trigger for the main branch means these tests won't run after PRs are merged to main. While merge_group should catch issues before merging, consider these scenarios:

  1. Direct pushes to main (if permitted) won't trigger tests
  2. Post-merge verification won't occur
  3. Branch protection may not have visibility into the health of the main branch

If your workflow relies exclusively on merge queues and direct pushes to main are disabled via branch protection, this may be acceptable. However, it's worth verifying that this aligns with your repository's branch protection rules and merge strategy.

Suggested change
on:
on:
push:
branches:
- main

Copilot uses AI. Check for mistakes.
push:
branches: [main]
merge_group:
pull_request:
env:
CARGO_TERM_COLOR: always
jobs:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/node_e2e_sysgo_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Sysgo E2E Tests
on:
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the pull_request trigger means these critical tests will not run on pull requests at all. This creates a significant workflow issue:

  1. Developers won't see test results during PR review
  2. Test failures will only be discovered in the merge queue, not during development
  3. This delays feedback and can block the merge queue with failing PRs

If the goal is to reduce CI usage, consider alternative approaches:

  • Use path filters to only run tests when relevant files change
  • Use conditional logic based on labels (e.g., only run on PRs labeled "ready-for-review")
  • Use workflow_run to trigger only after other checks pass
  • Keep pull_request but add conditions to skip on draft PRs

Completely removing pull_request triggers from test workflows is likely to cause more problems than it solves.

Suggested change
on:
on:
pull_request:
paths:
- 'node/**'
- 'tests/**'
- '.github/workflows/node_e2e_sysgo_tests.yaml'

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the push trigger for the main branch means these tests won't run after PRs are merged to main. While merge_group should catch issues before merging, consider these scenarios:

  1. Direct pushes to main (if permitted) won't trigger tests
  2. Post-merge verification won't occur
  3. Branch protection may not have visibility into the health of the main branch

If your workflow relies exclusively on merge queues and direct pushes to main are disabled via branch protection, this may be acceptable. However, it's worth verifying that this aligns with your repository's branch protection rules and merge strategy.

Suggested change
on:
on:
push:
branches:
- main

Copilot uses AI. Check for mistakes.
push:
branches: [main]
merge_group:
pull_request:
env:
CARGO_TERM_COLOR: always
jobs:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/proof.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Proof
on:
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the pull_request trigger means these critical tests will not run on pull requests at all. This creates a significant workflow issue:

  1. Developers won't see test results during PR review
  2. Test failures will only be discovered in the merge queue, not during development
  3. This delays feedback and can block the merge queue with failing PRs

If the goal is to reduce CI usage, consider alternative approaches:

  • Use path filters to only run tests when relevant files change
  • Use conditional logic based on labels (e.g., only run on PRs labeled "ready-for-review")
  • Use workflow_run to trigger only after other checks pass
  • Keep pull_request but add conditions to skip on draft PRs

Completely removing pull_request triggers from test workflows is likely to cause more problems than it solves.

Suggested change
on:
on:
pull_request:
paths:
- 'tests/**'
- '.github/**'
- 'justfile'
- 'Cargo.*'
- '**/Cargo.*'

Copilot uses AI. Check for mistakes.
push:
branches: [main]
merge_group:
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the push trigger for the main branch means these tests won't run after PRs are merged to main. While merge_group should catch issues before merging, consider these scenarios:

  1. Direct pushes to main (if permitted) won't trigger tests
  2. Post-merge verification won't occur
  3. Branch protection may not have visibility into the health of the main branch

If your workflow relies exclusively on merge queues and direct pushes to main are disabled via branch protection, this may be acceptable. However, it's worth verifying that this aligns with your repository's branch protection rules and merge strategy.

Suggested change
merge_group:
merge_group:
push:
branches:
- main

Copilot uses AI. Check for mistakes.
pull_request:

env:
CARGO_TERM_COLOR: always
Expand Down