Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix: use proper base fee params post-Canyon#3188

Merged
theochap merged 1 commit intoop-rs:mainfrom
risechain:kien-rise/canyon-params-0641
Dec 15, 2025
Merged

fix: use proper base fee params post-Canyon#3188
theochap merged 1 commit intoop-rs:mainfrom
risechain:kien-rise/canyon-params-0641

Conversation

@kien-rise
Copy link
Contributor

Fixes #2993

Copy link
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.9%. Comparing base (820ff00) to head (eb7a93d).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/protocol/genesis/src/chain/config.rs 0.0% 2 Missing ⚠️
crates/proof/executor/src/builder/env.rs 50.0% 1 Missing ⚠️
crates/protocol/genesis/src/params.rs 50.0% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theochap
Copy link
Member

theochap commented Dec 12, 2025

@kien-rise would you mind fixing the lint jobs?

@kien-rise kien-rise force-pushed the kien-rise/canyon-params-0641 branch from e6a60bc to eb7a93d Compare December 14, 2025 14:11
@kien-rise
Copy link
Contributor Author

@theochap I have fixed the CI error.

@theochap theochap added this pull request to the merge queue Dec 15, 2025
Merged via the queue into op-rs:main with commit 86910c9 Dec 15, 2025
47 checks passed
kien-rise added a commit to kien-rise/kona that referenced this pull request Dec 17, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect use of BaseFeeConfig::as_base_fee_params after Canyon activation

2 participants