Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(metrics): total sequenced transactions#3175

Merged
einar-oplabs merged 1 commit intomainfrom
einar/3092-total-transactions-sequenced-metric
Jan 9, 2026
Merged

feat(metrics): total sequenced transactions#3175
einar-oplabs merged 1 commit intomainfrom
einar/3092-total-transactions-sequenced-metric

Conversation

@einar-oplabs
Copy link
Collaborator

No description provided.

@einar-oplabs einar-oplabs linked an issue Dec 9, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.0%. Comparing base (6d30f52) to head (cec150c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rates/node/service/src/actors/sequencer/metrics.rs 0.0% 4 Missing ⚠️
crates/node/service/src/actors/sequencer/actor.rs 0.0% 3 Missing ⚠️
crates/protocol/protocol/src/attributes.rs 0.0% 3 Missing ⚠️
crates/node/service/src/metrics/mod.rs 0.0% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6d30f52) and HEAD (cec150c). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (6d30f52) HEAD (cec150c)
proof 11 0
e2e 11 0
unit 2 1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@einar-oplabs einar-oplabs force-pushed the einar/3092-total-transactions-sequenced-metric branch 3 times, most recently from 3c33408 to 022e7b0 Compare December 17, 2025 14:52
@einar-oplabs
Copy link
Collaborator Author

einar-oplabs commented Dec 17, 2025

There seem to be buggy behavior in the current version of the inc! macro. It has 3 arms, but it seems only arm 0 and 1 have been used in code. There are no tests. When trying to trigger the arm 2 (the one that allows for an increment parameter), it is actually matched by arm 1 instead, but then fails with leftover tokens. If I swap arm 1 and 2 it succeeds. However, I don't if that changes the behavior of other macro calls, so we need to feel comfortable before merging this one.

It is out of scope for this issue to debug and write tests for the metric macros.

@einar-oplabs einar-oplabs force-pushed the einar/3092-total-transactions-sequenced-metric branch 2 times, most recently from cc70127 to e77eb2a Compare December 18, 2025 14:43
@einar-oplabs
Copy link
Collaborator Author

I decided to not using the macro all together. I now consider the branch done and ready to merge. Please check everything looks right on your side @jelias2.

@einar-oplabs einar-oplabs marked this pull request as ready for review December 18, 2025 14:46
@einar-oplabs einar-oplabs force-pushed the einar/3092-total-transactions-sequenced-metric branch from e77eb2a to c103ad7 Compare January 6, 2026 15:58
@einar-oplabs einar-oplabs force-pushed the einar/3092-total-transactions-sequenced-metric branch from c103ad7 to cec150c Compare January 8, 2026 22:25
Copy link
Collaborator

@op-will op-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@einar-oplabs einar-oplabs added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 2845953 Jan 9, 2026
26 of 32 checks passed
@einar-oplabs einar-oplabs deleted the einar/3092-total-transactions-sequenced-metric branch January 9, 2026 00:15
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(sequencer): Add total transactions sequenced metric

3 participants