This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix(sources): migrate from rustls-pemfile to rustls-pki-types#3150
Merged
op-will merged 1 commit intoop-rs:mainfrom Dec 5, 2025
Merged
fix(sources): migrate from rustls-pemfile to rustls-pki-types#3150op-will merged 1 commit intoop-rs:mainfrom
op-will merged 1 commit intoop-rs:mainfrom
Conversation
Migrate PEM certificate parsing from the deprecated rustls-pemfile crate to rustls-pki-types which includes the same functionality since v1.10.0. This resolves RUSTSEC-2025-0134 advisory about rustls-pemfile being unmaintained. Closes op-rs#3149
Himess
requested review from
BioMark3r,
einar-oplabs,
emhane,
op-will and
theochap
as code owners
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. |
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…kona#3150) ## Changes - `crates/node/sources/src/signer/remote/cert.rs`: Use `CertificateDer::pem_file_iter` and `PrivateKeyDer::from_pem_file` instead of `rustls_pemfile` functions - `crates/node/sources/Cargo.toml`: Remove `rustls-pemfile` dependency - `Cargo.toml`: Remove `rustls-pemfile` from workspace dependencies Closes op-rs/kona#3149
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…kona#3150) ## Changes - `crates/node/sources/src/signer/remote/cert.rs`: Use `CertificateDer::pem_file_iter` and `PrivateKeyDer::from_pem_file` instead of `rustls_pemfile` functions - `crates/node/sources/Cargo.toml`: Remove `rustls-pemfile` dependency - `Cargo.toml`: Remove `rustls-pemfile` from workspace dependencies Closes #3149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
crates/node/sources/src/signer/remote/cert.rs: UseCertificateDer::pem_file_iterandPrivateKeyDer::from_pem_fileinstead ofrustls_pemfilefunctionscrates/node/sources/Cargo.toml: Removerustls-pemfiledependencyCargo.toml: Removerustls-pemfilefrom workspace dependenciesCloses #3149