Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

fix: Use bytecode_address instead of target_address#3117

Merged
theochap merged 2 commits intoop-rs:mainfrom
yoshidan:v1.2.4-patch
Dec 3, 2025
Merged

fix: Use bytecode_address instead of target_address#3117
theochap merged 2 commits intoop-rs:mainfrom
yoshidan:v1.2.4-patch

Conversation

@yoshidan
Copy link
Copy Markdown
Contributor

@yoshidan yoshidan commented Dec 1, 2025

Fix #3108

revm uses bytecode_address instead of address(target_address) in the following commit.

bluealloy/revm@827d572#diff-67a0a3d75e9fc8a8cc68e5a0bb2491ce63a1650aa75fab7d67621d31c7ab6c12

Copilot AI review requested due to automatic review settings December 1, 2025 10:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@theochap
Copy link
Copy Markdown
Member

theochap commented Dec 2, 2025

Can you add a unit test to make sure this works as expected?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.2%. Comparing base (be9d673) to head (9a6635f).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoshidan
Copy link
Copy Markdown
Contributor Author

yoshidan commented Dec 3, 2025

@theochap I added the unit test code by 9a6635f

Copy link
Copy Markdown
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for submitting that fix. I am good to merge

@theochap theochap enabled auto-merge December 3, 2025 15:45
@theochap theochap added this pull request to the merge queue Dec 3, 2025
Merged via the queue into op-rs:main with commit 2f7145f Dec 3, 2025
42 of 46 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derivation Failure on op-sepolia (Block 36150670 -> 36150671)

3 participants