Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore(proof): add panic message to exit syscall#3004

Merged
theochap merged 2 commits intoop-rs:mainfrom
saylor-mik87786:panic
Dec 3, 2025
Merged

chore(proof): add panic message to exit syscall#3004
theochap merged 2 commits intoop-rs:mainfrom
saylor-mik87786:panic

Conversation

@saylor-mik87786
Copy link
Contributor

@saylor-mik87786 saylor-mik87786 commented Nov 1, 2025

The exit syscall should never return, but the empty panic!() provides zero diagnostic value if it does. Reopen: #2986

@saylor-mik87786
Copy link
Contributor Author

saylor-mik87786 commented Nov 1, 2025 •
edited
Loading

Hi @einar-oplabs, included code as request. I accidentally messed up the branch and #2986 got auto-closed. Reopened it with the same fix.

@codecov
Copy link

codecov bot commented Nov 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.0%. Comparing base (409c341) to head (cffda1d).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@github-actions github-actions bot added M-stale and removed M-stale labels Nov 23, 2025
@saylor-mik87786
Copy link
Contributor Author

saylor-mik87786 commented Nov 27, 2025

Hi @emhane, could you please review this PR when you have a chance? Thanks!

@theochap theochap added this pull request to the merge queue Dec 3, 2025
Merged via the queue into op-rs:main with commit e800861 Dec 3, 2025
46 checks passed
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@saylor-mik87786
chore(proof): add panic message to exit syscall (op-rs/kona#3004)
ef60cda 
The `exit` syscall should never return, but the empty `panic!()`
provides zero diagnostic value if it does. Reopen:
op-rs/kona#2986
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@saylor-mik87786
chore(proof): add panic message to exit syscall (op-rs/kona#3004)
efe26c5 
The `exit` syscall should never return, but the empty `panic!()`
provides zero diagnostic value if it does. Reopen:
op-rs/kona#2986
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BioMark3r BioMark3r Awaiting requested review from BioMark3r

@emhane emhane Awaiting requested review from emhane

@op-will op-will Awaiting requested review from op-will op-will is a code owner

@einar-oplabs einar-oplabs Awaiting requested review from einar-oplabs einar-oplabs is a code owner

1 more reviewer

@theochap theochap theochap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saylor-mik87786 @theochap