This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(node): add sequencer key file loading support#2871
Merged
theochap merged 4 commits intoop-rs:mainfrom Dec 4, 2025
Merged
Conversation
mikemillaa
requested review from
BioMark3r,
dhyaniarun1993,
emhane,
itschaindev,
sadiq1971 and
theochap
as code owners
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. |
emhane
suggested changes
Sep 19, 2025
theochap
approved these changes
Sep 27, 2025
Member
|
@mikemillaa this looks good to me. Feel free to fix the tests and I will put that in the merge queue |
Contributor
Author
Hi I found some fmt and fix it, but I can't find the test you are mentioned above @theochap |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
emhane
reviewed
Oct 7, 2025
Contributor
Author
|
Hi @theochap let me know if this need more fix. :) |
Member
|
@mikemillaa would you mind rebasing on main and fixing the lint-native + test CI jobs? |
Add --p2p.sequencer.key.path parameter to load sequencer keys from files, matching the pattern used by --p2p.priv.path for regular P2P keys. - Add sequencer_key_path field to SignerArgs struct - Implement resolve_sequencer_key() method with file loading - Add ConflictingSequencerKeyInputs error for input validation - Add tests for file loading and conflict detection - Fix unreachable!() with proper error handling in conflict check
mikemillaa
force-pushed
the
p2pkeypair
branch
from
809e2b1 to
f4a651b
Compare
Contributor
Author
Should I clean codecov? how should it solved? |
theochap
approved these changes
Dec 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
Fixes design inconsistency where sequencer keys could only be passed via CLI args while regular P2P keys support file loading. This adds `--p2p.sequencer.key.path` parameter to match the existing `--p2p.priv.path` pattern. This resolves the[ TODO mentioned](https://github.com/ethereum-optimism/optimism/blob/44d3429d2913c8c90fbb0848e14c1022b8ca2267/op-devstack/sysgo/l2_cl_kona.go#L196) in optimism's devstack where they noted the missing file support for sequencer keys. --------- Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
Fixes design inconsistency where sequencer keys could only be passed via CLI args while regular P2P keys support file loading. This adds `--p2p.sequencer.key.path` parameter to match the existing `--p2p.priv.path` pattern. This resolves the[ TODO mentioned](https://github.com/ethereum-optimism/optimism/blob/44d3429d2913c8c90fbb0848e14c1022b8ca2267/op-devstack/sysgo/l2_cl_kona.go#L196) in optimism's devstack where they noted the missing file support for sequencer keys. --------- Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes design inconsistency where sequencer keys could only be passed via CLI args while regular P2P keys support file loading.
This adds
--p2p.sequencer.key.pathparameter to match the existing--p2p.priv.pathpattern.This resolves the TODO mentioned in optimism's devstack where they noted the missing file support for sequencer keys.