Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat: add inflight task metrics to engine queue#2860

Open
mikemillaa wants to merge 4 commits intoop-rs:mainfrom
mikemillaa:metric
Open

feat: add inflight task metrics to engine queue#2860
mikemillaa wants to merge 4 commits intoop-rs:mainfrom
mikemillaa:metric

Conversation

@mikemillaa
Copy link
Contributor

track inflight tasks by type in task queue

  • Add ENGINE_INFLIGHT_TASKS gauge metric with task type labels
  • Increment on enqueue, decrement on completion and queue clear
  • Conditionally compiled with 'metrics' feature

Seeing occasional slowdowns during high load periods
but couldn't tell if it was build tasks backing up or derivation
falling behind. This gives us per-task-type visibility to identify
which part of the pipeline is the bottleneck.

@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.1%. Comparing base (c978d7c) to head (fb3e86c).
⚠️ Report is 84 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls add a grafana panel for this to the dashboard and a screenshot of that panel to the pe description

@mikemillaa mikemillaa requested a review from emhane September 19, 2025 12:06
@mikemillaa
Copy link
Contributor Author

can you pls add a grafana panel for this to the dashboard and a screenshot of that panel to the pe description

@emhane Thanks for the review! I've added the requested Grafana panel to the existing dashboard.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@mikemillaa
Copy link
Contributor Author

@emhane @theochap Hi would you plz check this? In case this close

@github-actions github-actions bot removed the M-stale label Oct 12, 2025
@theochap
Copy link
Member

@emhane how does this PR look to you now? Is it good to merge?

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@github-actions github-actions bot added M-stale and removed M-stale labels Nov 13, 2025
@mikemillaa
Copy link
Contributor Author

@theochap in case closing

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@mikemillaa
Copy link
Contributor Author

@theochap

@github-actions github-actions bot removed the M-stale label Dec 10, 2025
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@github-actions github-actions bot added M-stale and removed M-stale labels Dec 31, 2025
@mikemillaa
Copy link
Contributor Author

@emhane @theochap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants