chore(ci): fix supervisor sysgo test path

[dhyaniarun1993]

No description provided.

[Copilot]

Pull Request Overview

This PR fixes a test path in the GitHub Actions workflow configuration for supervisor end-to-end tests with SysGo. The change corrects the path from "l1_reorg/sysgo" to "l1reorg/sysgo" by removing an underscore.

• Updates the test package path in the matrix configuration to use the correct directory structure

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[claude]

Claude finished @dhyaniarun1993's task —— View job

---

Code Review Complete ✅

Todo List:

• Read the modified workflow file to understand the change
• Verify the directory structure to confirm the path correction
• Check for any related files that might be affected
• Analyze potential impact on CI/CD pipeline
• Provide comprehensive review feedback

Review Feedback

✅ This is a correct and necessary fix!

Code Quality & Best Practices

• Perfect: The change is minimal, focused, and addresses the exact issue
• Correct Path Fix: Changed l1_reorg/sysgo → l1reorg/sysgo to match actual directory structure
• Consistent: Maintains the same pattern as the other test package (pre_interop)

Verification of Fix

I confirmed the directory structure in the repository:

• ✅ Exists: /tests/supervisor/l1reorg/sysgo/ (correct path)
• ❌ Missing: /tests/supervisor/l1_reorg/sysgo/ (old incorrect path with underscore)

The tests in this directory include:

• tests/supervisor/l1reorg/sysgo/init_test.go
• tests/supervisor/l1reorg/sysgo/reorg_test.go

Potential Issues

None identified. This fix addresses:

• ✅ CI test discovery failure due to wrong path
• ✅ Prevents silent test skipping
• ✅ Ensures proper E2E test execution for supervisor with SysGo orchestrator

Performance Considerations

• Neutral impact: No performance implications, just fixes test execution path
• Positive: Will now properly execute the intended tests that were being skipped

Security Concerns

• None: This is a path correction in a CI configuration, no security implications

Test Coverage

• Improved: This fix actually restores test coverage by ensuring the l1reorg/sysgo tests run
• Context: The just test-e2e-sysgo command expects the path format used in this fix (./$GO_PKG_NAME)
• Matrix Strategy: Both pre_interop and l1reorg/sysgo will now execute correctly

Recommendation

✅ APPROVE - This is a straightforward bug fix that resolves a CI path issue and ensures proper test execution.

[claude]

Claude finished @dhyaniarun1993's task —— View job

---

Pull Request Review

Reviewing PR #2826: "chore(ci): fix supervisor sysgo test path"

Todo List:

• Read the modified workflow file
• Examine directory structure to validate the path fix
• Check for consistency with other workflow files
• Analyze for code quality, bugs, performance, security, and test coverage
• Provide comprehensive review feedback

Code Review

Summary: This PR fixes a path correction in the GitHub Actions workflow for supervisor end-to-end tests with SysGo, changing "l1_reorg/sysgo" to "l1reorg/sysgo" (removing the underscore).

Analysis by Category

✅ Code Quality & Best Practices

• Correct Fix: The path correction is accurate - verified that the actual directory structure uses l1reorg/ (without underscore) at /home/runner/work/kona/kona/tests/supervisor/l1reorg/sysgo/
• Consistency: The fix aligns with the kurtosis workflow which already uses the correct path l1reorg/kurtosis (.github/workflows/supervisor_e2e_kurtosis.yaml:22)
• Minimal Change: Appropriately focused change that fixes only what's needed

🔍 Potential Issues

• None identified: This is a straightforward path correction with no logical issues
• Validation: Directory structure confirmed to exist at the corrected path
• Test Impact: The change should allow the failing tests to find the correct test files

⚡ Performance Considerations

• No Impact: Path corrections have no performance implications
• Workflow Efficiency: Fixing the path will prevent test failures and unnecessary workflow runs

🔒 Security Concerns

• No Security Issues: Path correction poses no security risks
• Appropriate Scope: The change is limited to test execution paths

🧪 Test Coverage

• Fix Enables Tests: The correction allows the supervisor sysgo tests to run properly
• Test Structure: Validated that test files exist at:
  • tests/supervisor/l1reorg/sysgo/init_test.go
  • tests/supervisor/l1reorg/sysgo/reorg_test.go
• Matrix Strategy: The workflow matrix correctly includes both test packages: ["pre_interop", "l1reorg/sysgo"]

Additional Observations

1. Historical Context: This appears to be correcting a typo that was likely introduced when the workflow was initially created
2. Workflow Pattern: The justfile command test-e2e-sysgo supervisor "/supervisor/${{ matrix.test-pkg }}" will now correctly resolve to /supervisor/l1reorg/sysgo
3. Consistency Check: Other workflows using similar paths are already correct (kurtosis workflow)

Recommendation

✅ APPROVED - This is a necessary bug fix that corrects a path typo preventing tests from running. The change is minimal, correct, and safe.

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.0%. Comparing base (88cb2c7) to head (8d674d0).
⚠️ Report is 1 commits behind head on main.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.