Conversation
mikemillaa
requested review from
dhyaniarun1993,
emhane,
itschaindev,
refcell,
sadiq1971 and
theochap
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
|
|
||
| # Reth (pinned to v1.4.8 for kona-supervisor-storage) | ||
| # Reth (pinned to v1.6.0 for kona-supervisor-storage) | ||
| reth-db-api = { git = "https://github.com/paradigmxyz/reth", tag = "v1.6.0" } | ||
| reth-db = { git = "https://github.com/paradigmxyz/reth", tag = "v1.6.0" } | ||
| reth-codecs = { git = "https://github.com/paradigmxyz/reth", tag = "v1.6.0" } |
There was a problem hiding this comment.
nice catch. this means we can also use the latest version from crates.io. could you pls remove the git and tag kv in favour of just having the version kv, like other deps
There was a problem hiding this comment.
Member
Thanks! I checked crates.io — these crates (reth-db-api, reth-db, reth-codecs) aren’t published yet. should we keep the git+tag at v1.6.0 for now? If there’s a different crate name we should use, happy to update. what‘s your thought of this? @emhane
|
Is this good to go? @emhane |
Sync reth version, apparently the version is v1.6.0 now Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sync reth version, apparently the version is v1.6.0 now Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
3 participants
Sync reth version, apparently the version is v1.6.0 now