feat(node/test): improve connection drop tests

[theochap]

Description

Simple PR that improves the connection drop tests by ensuring that the unsafe head doesn't advance before consolidation

[claude]

Claude finished @theochap's task —— View job

---

PR Review: Connection Drop Test Improvements

I'm reviewing the changes to improve connection drop tests. Here's my progress:

Todo List:

• Read and analyze all changed files
• Review the connection drop test improvements
• Analyze code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security concerns
• Assess test coverage improvements
• Provide comprehensive feedback

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.0%. Comparing base (b68d533) to head (2b64d34).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull Request Overview

This PR improves the connection drop tests by refactoring WebSocket utilities and enhancing test reliability. The changes focus on ensuring proper test timing by preventing unsafe head advancement before consolidation during connection drop scenarios.

• Moves WebSocket utilities from tests/node/common/ws.go to a more centralized location with enhanced functionality
• Improves connection drop test logic to verify that unsafe heads don't advance during disconnection periods
• Refactors test functions to use the new WebSocket utility location

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/node/utils/ws.go	New centralized WebSocket utilities with async support and improved error handling
tests/node/restart/restart_test.go	Simplifies sequencer head advancement check logic
tests/node/restart/conn_drop_test.go	Enhanced connection drop tests with unsafe head monitoring and improved sync verification
tests/node/common/ws.go	Removed old WebSocket utilities (moved to utils)
tests/node/common/sync_ws_test.go	Updated imports to use new WebSocket utility location
tests/node/common/engine_test.go	Updated imports to use new WebSocket utility location

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The logic for checking if numbers are within delta range is incorrect. The condition should use >= for the lower bound and <= for the upper bound. Currently, it will always be true since any number is either <= (base + delta) OR >= (base - delta).

Suggested change

	if ref.Number <= base.Number+delta || ref.Number >= base.Number-delta {
	if ref.Number >= base.Number-delta && ref.Number <= base.Number+delta {

[Copilot]

The assertions compare block.BlockRef properties with base properties, but block is fetched using ref.Number while the assertions expect it to match base. This will fail when ref.Number != base.Number, which is the expected case when checking if nodes are within delta range.