feat(node/e2e-tests): refactor test package

[theochap]

Description

Try to restructure e2e tests go package to prevent race conditions in CI

[claude]

Claude finished @theochap's task —— View job

---

PR Review: Restructure e2e Test Package

Review Checklist:

• Analyze the package restructuring changes
• Review Go test package naming and organization
• Check workflow file updates
• Evaluate race condition prevention approach
• Assess code quality and best practices
• Check for potential bugs or issues
• Provide comprehensive feedback

Analysis Summary

This PR restructures the Go e2e test packages to prevent race conditions in CI. Here's my comprehensive review:

✅ Positive Changes

Package Organization:

• Clear separation: Tests are now properly separated into distinct packages (node, node_kurtosis, node_restart, node_sysgo, node_utils)
• Better isolation: Each test suite now has its own package namespace, reducing potential conflicts
• Logical grouping: Related functionality moved to appropriate packages (restart tests → node_restart, utilities → node_utils)

Workflow Integration:

• Workflows correctly updated to run tests from new package locations
• Added node/restart test execution to both Kurtosis and Sysgo workflows

🔍 Race Condition Prevention

The restructuring addresses race conditions through:

1. Package Isolation: Different test suites no longer share the same package namespace
2. Separate TestMain Functions: Each package now has its own TestMain with isolated test setups
3. Distinct Import Paths: Prevents Go's package caching from causing conflicts between test runs

📋 Code Quality Assessment

Strengths:

• Consistent naming: Package names follow Go conventions (node_* pattern)
• Proper imports: All import paths updated correctly to use node_utils
• Clean separation: No shared global state between test packages
• Maintained functionality: Test logic remains unchanged, only organizational improvements

⚠️ Minor Considerations

1. Import alias consistency: The import alias node_utils "github.com/op-rs/kona/node/utils" is used consistently across all files ✅

2. Package naming: While node_* naming works, consider if shorter names like kurtosis, restart, sysgo would be more idiomatic (though current approach is acceptable)

3. Test isolation: The new structure properly isolates test execution contexts, which should resolve the CI race conditions

🚀 Overall Assessment

This is a well-executed refactoring that:

• ✅ Addresses the stated goal of preventing race conditions
• ✅ Improves code organization and maintainability
• ✅ Maintains all existing test functionality
• ✅ Updates workflows correctly
• ✅ Follows Go best practices

Recommendation: APPROVE - This change effectively addresses the race condition issues while improving the overall test structure.

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.2%. Comparing base (4bbadea) to head (e9f9871).
⚠️ Report is 1 commits behind head on theo/restart-tests.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.